[U-Boot] [PATCH 01/15 V3] iMX28: Initial support for iMX28 CPU

Marek Vasut
2011-10-14T21:10:58Z

On Friday, October 14, 2011 11:01:23 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
>
> In message <1317375728-23802-1-git-send-email-marek.vasut@gmail.com> you
wrote:
> > This patch supports:
> > - Timers
> > - Debug UART
> > - Clock
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Detlev Zundel <dzu@denx.de>
> > ---
> >
> > arch/arm/cpu/arm926ejs/mx28/Makefile | 46 +
> > arch/arm/cpu/arm926ejs/mx28/clock.c | 355 +++++++
> > arch/arm/cpu/arm926ejs/mx28/mx28.c | 194 ++++
> > arch/arm/cpu/arm926ejs/mx28/timer.c | 141 +++
> > arch/arm/include/asm/arch-mx28/clock.h | 61 ++
> > arch/arm/include/asm/arch-mx28/imx-regs.h | 38 +
> > arch/arm/include/asm/arch-mx28/regs-base.h | 88 ++
> > arch/arm/include/asm/arch-mx28/regs-bch.h | 230 +++++
> > arch/arm/include/asm/arch-mx28/regs-clkctrl.h | 312 ++++++
> > arch/arm/include/asm/arch-mx28/regs-common.h | 66 ++
> > arch/arm/include/asm/arch-mx28/regs-gpmi.h | 222 +++++
> > arch/arm/include/asm/arch-mx28/regs-i2c.h | 207 ++++
> > arch/arm/include/asm/arch-mx28/regs-ocotp.h | 173 ++++
> > arch/arm/include/asm/arch-mx28/regs-pinctrl.h | 1284
> > +++++++++++++++++++++++++ arch/arm/include/asm/arch-mx28/regs-power.h
> > | 413 ++++++++
> > arch/arm/include/asm/arch-mx28/regs-rtc.h | 147 +++
> > arch/arm/include/asm/arch-mx28/regs-ssp.h | 349 +++++++
> > arch/arm/include/asm/arch-mx28/regs-timrot.h | 171 ++++
> > arch/arm/include/asm/arch-mx28/sys_proto.h | 30 +
> > 19 files changed, 4527 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/Makefile
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/clock.c
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/mx28.c
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/timer.c
> > create mode 100644 arch/arm/include/asm/arch-mx28/clock.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/imx-regs.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-base.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-bch.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-clkctrl.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-common.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-gpmi.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-i2c.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-ocotp.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-pinctrl.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-power.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-rtc.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-ssp.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-timrot.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/sys_proto.h
>
> ...
>
> > +#include <common.h>
> > +#include <asm/errno.h>
> > +#include <asm/io.h>
> > +#include <asm/arch/clock.h>
> > +#include <asm/arch/gpio.h>
> > +#include <asm/arch/imx-regs.h>
> > +#include <asm/arch/sys_proto.h>
> > +#include <asm/arch/iomux-mx28.h>
>
> You include <asm/arch/iomux-mx28.h> here, but add this file only in
> patch # 4 of your series. That means your patches are not bisectable.

Good catch, it must have crawled in when I was debugging the reset issue.
Dropping the include does the trick, thanks for your constant torture! ;-)

Fix in V4 on the way!

Cheers