* [U-Boot] [PATCH] MX51: vision2: Set global macros
@ 2011-09-28 10:09 Stefano Babic
2011-09-29 1:34 ` Marek Vasut
2011-10-05 10:08 ` [U-Boot] [PATCH V2] " Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Stefano Babic @ 2011-09-28 10:09 UTC (permalink / raw)
To: u-boot
Adapt vision2 to the current u-boot version. Drop
own macros to set global data and use the common ones.
Signed-off-by: Stefano Babic <sbabic@denx.de>
---
include/configs/vision2.h | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/configs/vision2.h b/include/configs/vision2.h
index 16ed975..c07cee4 100644
--- a/include/configs/vision2.h
+++ b/include/configs/vision2.h
@@ -192,14 +192,15 @@
#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)
#define PHYS_SDRAM_2 CSD1_BASE_ADDR
#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024)
-#define CONFIG_SYS_SDRAM_BASE 0x90000000
-#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000
-
-#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024)
-#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \
- GENERATED_GBL_DATA_SIZE)
-#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
- CONFIG_SYS_GBL_DATA_OFFSET)
+#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1)
+#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR)
+#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE)
+
+#define CONFIG_SYS_INIT_SP_OFFSET \
+ (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR \
+ (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+
#define CONFIG_BOARD_EARLY_INIT_F
/* 166 MHz DDR RAM */
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX51: vision2: Set global macros
2011-09-28 10:09 [U-Boot] [PATCH] MX51: vision2: Set global macros Stefano Babic
@ 2011-09-29 1:34 ` Marek Vasut
2011-09-29 13:27 ` Stefano Babic
2011-10-05 10:08 ` [U-Boot] [PATCH V2] " Stefano Babic
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2011-09-29 1:34 UTC (permalink / raw)
To: u-boot
On Wednesday, September 28, 2011 12:09:17 PM Stefano Babic wrote:
> Adapt vision2 to the current u-boot version. Drop
> own macros to set global data and use the common ones.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> include/configs/vision2.h | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/include/configs/vision2.h b/include/configs/vision2.h
> index 16ed975..c07cee4 100644
> --- a/include/configs/vision2.h
> +++ b/include/configs/vision2.h
> @@ -192,14 +192,15 @@
> #define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)
> #define PHYS_SDRAM_2 CSD1_BASE_ADDR
> #define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024)
> -#define CONFIG_SYS_SDRAM_BASE 0x90000000
> -#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000
> -
> -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024)
> -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \
> - GENERATED_GBL_DATA_SIZE)
> -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
> - CONFIG_SYS_GBL_DATA_OFFSET)
> +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1)
> +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR)
> +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE)
Arent the parentheses redundant here?
Cheers
> +
> +#define CONFIG_SYS_INIT_SP_OFFSET \
> + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
> +#define CONFIG_SYS_INIT_SP_ADDR \
> + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
> +
> #define CONFIG_BOARD_EARLY_INIT_F
>
> /* 166 MHz DDR RAM */
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX51: vision2: Set global macros
2011-09-29 1:34 ` Marek Vasut
@ 2011-09-29 13:27 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-09-29 13:27 UTC (permalink / raw)
To: u-boot
On 09/29/2011 03:34 AM, Marek Vasut wrote:
> On Wednesday, September 28, 2011 12:09:17 PM Stefano Babic wrote:
>> Adapt vision2 to the current u-boot version. Drop
>> own macros to set global data and use the common ones.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>> include/configs/vision2.h | 17 +++++++++--------
>> 1 files changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/configs/vision2.h b/include/configs/vision2.h
>> index 16ed975..c07cee4 100644
>> --- a/include/configs/vision2.h
>> +++ b/include/configs/vision2.h
>> @@ -192,14 +192,15 @@
>> #define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)
>> #define PHYS_SDRAM_2 CSD1_BASE_ADDR
>> #define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024)
>> -#define CONFIG_SYS_SDRAM_BASE 0x90000000
>> -#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000
>> -
>> -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024)
>> -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \
>> - GENERATED_GBL_DATA_SIZE)
>> -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
>> - CONFIG_SYS_GBL_DATA_OFFSET)
>> +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1)
>> +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR)
>> +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE)
>
> Arent the parentheses redundant here?
I will drop in V2.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2] MX51: vision2: Set global macros
2011-09-28 10:09 [U-Boot] [PATCH] MX51: vision2: Set global macros Stefano Babic
2011-09-29 1:34 ` Marek Vasut
@ 2011-10-05 10:08 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-10-05 10:08 UTC (permalink / raw)
To: u-boot
Adapt vision2 to the current u-boot version. Drop
own macros to set global data and use the common ones.
Signed-off-by: Stefano Babic <sbabic@denx.de>
---
Changes:
- drop redundant parentheses
include/configs/vision2.h | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/configs/vision2.h b/include/configs/vision2.h
index 16ed975..d4e80bc 100644
--- a/include/configs/vision2.h
+++ b/include/configs/vision2.h
@@ -192,14 +192,15 @@
#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)
#define PHYS_SDRAM_2 CSD1_BASE_ADDR
#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024)
-#define CONFIG_SYS_SDRAM_BASE 0x90000000
-#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000
-
-#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024)
-#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \
- GENERATED_GBL_DATA_SIZE)
-#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \
- CONFIG_SYS_GBL_DATA_OFFSET)
+#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_RAM_ADDR IRAM_BASE_ADDR
+#define CONFIG_SYS_INIT_RAM_SIZE IRAM_SIZE
+
+#define CONFIG_SYS_INIT_SP_OFFSET \
+ (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR \
+ (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+
#define CONFIG_BOARD_EARLY_INIT_F
/* 166 MHz DDR RAM */
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-05 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-28 10:09 [U-Boot] [PATCH] MX51: vision2: Set global macros Stefano Babic
2011-09-29 1:34 ` Marek Vasut
2011-09-29 13:27 ` Stefano Babic
2011-10-05 10:08 ` [U-Boot] [PATCH V2] " Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox