[U-Boot] [PATCH] cfi_flash driver: fixed addressing for 8-bit flash buses.

Wolfgang Denk
2011-04-30T19:12:10Z

Dear Aaron Williams,

In message <1302594796-26276-1-git-send-email-aaron.williams@caviumnetworks.com> you wrote:
> This patch corrects the addresses used when working with Spansion/AMD FLASH
> chips. Addressing for 8 and 16 bits is almost identical except in the 16
> bit case the LSB of the address is always 0. The confusion arose because
> the addresses in the datasheet for the 16 bit mode are word addresses but
> the CFI driver assumed they were byte addresses.
>
> I have only been able to test this on our Octeon boards which use either
> an 8 or 16 bit bus. I have not tested 32-bits or when there are multiple
> parts in parallel on a wider bus.
>
> Several other people have also reported success with this patch.
>
> -Aaron Williams
>
>
> Signed-off-by: Aaron Williams <aaron.williams@caviumnetworks.com>
> ---
> drivers/mtd/cfi_flash.c | 66 +++++++++++++++++++++++++++++++---------------
> include/mtd/cfi_flash.h | 43 ++++++++++++++++--------------
> 2 files changed, 67 insertions(+), 42 deletions(-)

This patch has a number of coding style isses (trailing whitespace,
space between function name and open parenthesis, line over 80
characters, etc.)

Please clean up and resubmit (after verifying the patch using
checkpatch).

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The evolution of the human race will not be accomplished in the ten
thousand years of tame animals, but in the million years of wild
animals, because man is and will always be a wild animal.
- Charles Galton Darwin