From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] da850: add support to read mac address from spi flash
Date: Fri, 30 Sep 2011 11:51:34 -0400 [thread overview]
Message-ID: <201109301151.35523.vapier@gentoo.org> (raw)
In-Reply-To: <1317381867-18981-6-git-send-email-nagabhushana.netagunte@ti.com>
On Friday, September 30, 2011 07:24:26 nagabhushana.netagunte at ti.com wrote:
> + if (is_multicast_ether_addr(buff) ||
> + is_zero_ether_addr(buff)) {
NAK: use is_valid_ether_addr()
> + sprintf((char *)enetaddr, "%pM", buff);
> +
> + eth_setenv_enetaddr("ethaddr", enetaddr);
NAK: eth_setenv_enetaddr() does the sprintf for you
-mike
next prev parent reply other threads:[~2011-09-30 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 11:24 [U-Boot] [PATCH 0/6] da850: add board specific functions nagabhushana.netagunte at ti.com
2011-09-30 11:24 ` [U-Boot] [PATCH 1/6] da850: add new config file for AM18xx nagabhushana.netagunte at ti.com
2011-09-30 11:24 ` [U-Boot] [PATCH 2/6] da850: rename config file to represent OMAP-L138 nagabhushana.netagunte at ti.com
2011-09-30 11:24 ` [U-Boot] [PATCH 3/6] da850: pass board revision info to kernel nagabhushana.netagunte at ti.com
2011-09-30 11:24 ` [U-Boot] [PATCH 4/6] da850: revert cache disable patch nagabhushana.netagunte at ti.com
2011-09-30 21:48 ` Laurence Withers
2011-10-04 13:47 ` Netagunte, Nagabhushana
2011-09-30 11:24 ` [U-Boot] [PATCH 5/6] da850: add support to read mac address from spi flash nagabhushana.netagunte at ti.com
2011-09-30 15:51 ` Mike Frysinger [this message]
2011-10-08 9:08 ` Hadli, Manjunath
2011-09-30 11:24 ` [U-Boot] [PATCH 6/6] da850: read MAC address from I2C EEPROM on AM18xx EVM nagabhushana.netagunte at ti.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109301151.35523.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox