From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 30 Sep 2011 11:51:34 -0400
Subject: [U-Boot] [PATCH 5/6] da850: add support to read mac address
	from spi flash
In-Reply-To: <1317381867-18981-6-git-send-email-nagabhushana.netagunte@ti.com>
References: <1317381867-18981-1-git-send-email-nagabhushana.netagunte@ti.com>
	<1317381867-18981-6-git-send-email-nagabhushana.netagunte@ti.com>
Message-ID: <201109301151.35523.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, September 30, 2011 07:24:26 nagabhushana.netagunte at ti.com wrote:
> +		if (is_multicast_ether_addr(buff) ||
> +				is_zero_ether_addr(buff)) {

NAK: use is_valid_ether_addr()

> +		sprintf((char *)enetaddr, "%pM", buff);
> +
> +		eth_setenv_enetaddr("ethaddr", enetaddr);

NAK: eth_setenv_enetaddr() does the sprintf for you
-mike