From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: turn off cache: set control register properly
Date: Fri, 30 Sep 2011 22:24:43 +0200 [thread overview]
Message-ID: <201109302224.43352.marek.vasut@gmail.com> (raw)
In-Reply-To: <1317407227-8864-1-git-send-email-ondra.cap@gmail.com>
On Friday, September 30, 2011 08:27:07 PM Ondrej Kupka wrote:
> Bits should be ORed when they are supposed to be added together
>
> Cc: Graeme Russ <graeme.russ@gmail.com>
> Signed-off-by: Ondrej Kupka <ondra.cap@gmail.com>
> ---
> arch/x86/cpu/start16.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S
> index 3d3017a..9dabff2 100644
> --- a/arch/x86/cpu/start16.S
> +++ b/arch/x86/cpu/start16.S
> @@ -50,7 +50,7 @@ board_init16_ret:
>
> /* Turn of cache (this might require a 486-class CPU) */
> movl %cr0, %eax
> - orl $(X86_CR0_NW & X86_CR0_CD), %eax
> + orl $(X86_CR0_NW | X86_CR0_CD), %eax
> movl %eax, %cr0
> wbinvd
Dear Ondrej Kupka,
Can we make this into some macro so we'd avoid such errors in the future ?
Cheers
next prev parent reply other threads:[~2011-09-30 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 18:27 [U-Boot] [PATCH] x86: turn off cache: set control register properly Ondrej Kupka
2011-09-30 20:24 ` Marek Vasut [this message]
2011-09-30 20:56 ` Ondra Kupka
2011-09-30 21:01 ` Marek Vasut
2011-10-16 3:21 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109302224.43352.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox