From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 3 Oct 2011 02:10:25 -0400
Subject: [U-Boot] [PATCH v3 05/21] sandbox: Add cpu files
In-Reply-To: <1317082255-24247-6-git-send-email-sjg@chromium.org>
References: <1317082255-24247-1-git-send-email-sjg@chromium.org>
	<1317082255-24247-6-git-send-email-sjg@chromium.org>
Message-ID: <201110030210.27447.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 26, 2011 20:10:39 Simon Glass wrote:
> --- /dev/null
> +++ b/arch/sandbox/cpu/cpu.c
>
> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> +	/*
> +	 * This is considered normal termination for now. We wil call os_exit()
> +	 * when available.
> +	 */
> +	return 0;
> +}

os_exit(0) ?

> +int cleanup_before_linux(void)
> +{
> +	return 0;
> +}

this is an ARM wart ... drop it

> +void *map_physmem(phys_addr_t paddr, unsigned long len, unsigned long
> flags)
> +{
> +	return (void *)(gd->ram_buf + paddr);
> +}

please add a comment as to why you need this trickery
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111003/0db24f82/attachment.pgp