From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 3 Oct 2011 15:31:59 -0400 Subject: [U-Boot] [PATCH v3 21/21] sandbox: Makefile changes to build sandbox architecture In-Reply-To: <1317082255-24247-22-git-send-email-sjg@chromium.org> References: <1317082255-24247-1-git-send-email-sjg@chromium.org> <1317082255-24247-22-git-send-email-sjg@chromium.org> Message-ID: <201110031532.00523.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, September 26, 2011 20:10:55 Simon Glass wrote: > --- a/Makefile > +++ b/Makefile > > +ifneq ($(CPU),sandbox) > OBJS = $(CPUDIR)/start.o > +endif if you moved arch/sandbox/common/main.c to arch/sandbox/cpu/start.c, you wouldn't need this. and logically, it seems like a good place for main() to be ... > +ifeq ($(CONFIG_SANDBOX),y) > +GEN_UBOOT = \ > + cd $(LNDIR) && $(CC) $(SYMS) -T $(obj)u-boot.lds \ > + -Wl,--start-group $(__LIBS) -Wl,--end-group \ > + $(PLATFORM_LIBS) -Wl,-Map -Wl,u-boot.map -o u-boot unfortunate that you can't utilize UNDEF_SYM ... > GEN_UBOOT = \ > - UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \ > - sed -n -e 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p'|sort|uniq`; > + UNDEF_SYM=`$(UNDEF)`; \ i don't see you defining "UNDEF" anywhere in this patch series ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111003/ac25b4cd/attachment.pgp