From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Tue, 4 Oct 2011 14:07:20 +0200
Subject: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define
In-Reply-To: <1317710111-9588-2-git-send-email-leiwen@marvell.com>
References: <1317632636-12688-1-git-send-email-leiwen@marvell.com>
	<1317710111-9588-2-git-send-email-leiwen@marvell.com>
Message-ID: <201110041407.20860.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, October 04, 2011 08:35:10 AM Lei Wen wrote:
> Previous magic number is hard to parse its meaning, change it to
> respective macro definition
> 
> Signed-off-by: Lei Wen <leiwen@marvell.com>

[..]

> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -145,13 +145,15 @@
>  /*
>   * EXT_CSD fields
>   */
> -
> -#define EXT_CSD_PART_CONF	179	/* R/W */
> -#define EXT_CSD_BUS_WIDTH	183	/* R/W */
> -#define EXT_CSD_HS_TIMING	185	/* R/W */
> -#define EXT_CSD_CARD_TYPE	196	/* RO */
> -#define EXT_CSD_REV		192	/* RO */
> -#define EXT_CSD_SEC_CNT		212	/* RO, 4 bytes */
> +#define EXT_CSD_PARTITIONING_SUPPORT	160	/* RO */
> +#define EXT_CSD_ERASE_GROUP_DEF		175	/* R/W */
> +#define EXT_CSD_PART_CONF		179	/* R/W */
> +#define EXT_CSD_BUS_WIDTH		183	/* R/W */
> +#define EXT_CSD_HS_TIMING		185	/* R/W */
> +#define EXT_CSD_REV			192	/* RO */
> +#define EXT_CSD_CARD_TYPE		196	/* RO */
> +#define EXT_CSD_SEC_CNT			212	/* RO, 4 bytes */
> +#define EXT_CSD_HC_ERASE_GRP_SIZE	224	/* RO */
> 
>  /*
>   * EXT_CSD field definitions

Hi Lei,
this is better, but what about structure-based access ?

struct somrthing {
 u8 a1;
 u8 a2;
...
};

Like this.

Also, CC Andy.

Cheers