From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Tegra2: Make XTal speed configurable
Date: Wed, 5 Oct 2011 19:05:37 +0200 [thread overview]
Message-ID: <201110051905.37800.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAPnjgZ22QgHk_ji2pb5TRB+yZ_4eOiurvn3Sy=DaigYTTVoZLA@mail.gmail.com>
On Wednesday, October 05, 2011 04:10:56 PM Simon Glass wrote:
> Hi Marek,
>
> On Fri, Sep 30, 2011 at 5:12 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > The Toradex T20 module uses 13MHz Xtal, so make the Xtal speed
> > configurable.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Ben Warren <biggerbadderben@gmail.com>
> > Cc: Tom Warren <twarren.nvidia@gmail.com>
> > Cc: Stephen Warren <swarren@nvidia.com>
> > ---
> > arch/arm/cpu/armv7/tegra2/ap20.c | 9 +++++++--
> > 1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c
> > b/arch/arm/cpu/armv7/tegra2/ap20.c index dc5f984..71d9f26 100644
> > --- a/arch/arm/cpu/armv7/tegra2/ap20.c
> > +++ b/arch/arm/cpu/armv7/tegra2/ap20.c
> > @@ -31,6 +31,11 @@
> > #include <asm/arch/scu.h>
> > #include <common.h>
> >
> > +/* The default XTal is 12MHz, some boards might use 13MHz one though */
> > +#ifndef CONFIG_SYS_TEGRA2_XTAL_MHZ
> > +#define CONFIG_SYS_TEGRA2_XTAL_MHZ 12
> > +#endif
> > +
> > u32 s_first_boot = 1;
> >
> > void init_pllx(void)
> > @@ -46,8 +51,8 @@ void init_pllx(void)
> > /* Set PLLX_MISC */
> > writel(1 << PLL_CPCON_SHIFT, &pll->pll_misc);
> >
> > - /* Use 12MHz clock here */
> > - reg = PLL_BYPASS_MASK | (12 << PLL_DIVM_SHIFT);
> > + /* Use 13MHz clock here */
>
> Change comment?
>
> > + reg = PLL_BYPASS_MASK | (CONFIG_SYS_TEGRA2_XTAL_MHZ <<
> > PLL_DIVM_SHIFT); reg |= 1000 << PLL_DIVN_SHIFT;
> > writel(reg, &pll->pll_base);
> >
> > --
> > 1.7.5.4
>
> Regards,
> Simon
Hi Simon, I'll probably also change the board.c to support this. But then, can't
the board.c be moved to arch/arm/cpu/armv7/tegra... and it's functions exported
via standard header ? Cheers
next prev parent reply other threads:[~2011-10-05 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 0:12 [U-Boot] [PATCH 1/2] Tegra2: Make XTal speed configurable Marek Vasut
2011-10-01 0:12 ` [U-Boot] [PATCH 2/2] Tegra2: Add support for Toradex Colibri T20 board Marek Vasut
2011-10-03 3:52 ` Simon Glass
2011-10-03 10:35 ` Marek Vasut
2011-10-03 16:09 ` Stephen Warren
2011-10-03 23:42 ` Simon Glass
2011-10-05 14:10 ` [U-Boot] [PATCH 1/2] Tegra2: Make XTal speed configurable Simon Glass
2011-10-05 17:05 ` Marek Vasut [this message]
2011-10-12 0:30 ` Simon Glass
2011-10-12 11:19 ` Marek Vasut
2011-10-12 21:17 ` Simon Glass
2011-10-13 0:27 ` Marek Vasut
2011-10-13 4:31 ` Simon Glass
2011-10-13 14:04 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110051905.37800.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).