[U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library

Marek Vasut
2011-09-16T21:38:34Z

On Friday, September 16, 2011 09:49:28 PM Scott Wood wrote:
> On 09/15/2011 06:17 PM, Marek Vasut wrote:
> > On Friday, September 16, 2011 12:57:44 AM Scott Wood wrote:
> >> On 09/11/2011 11:03 PM, Marek Vasut wrote:
> >>> Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU
> >>> support library. This can be useful on some setups.
> >>>
> >>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >>> Cc: Stefano Babic <sbabic@denx.de>
> >>> Cc: Wolfgang Denk <wd@denx.de>
> >>> Cc: Detlev Zundel <dzu@denx.de>
> >>> Cc: Chander Kashyap <chander.kashyap@linaro.org>
> >>
> >> But you didn't CC these...
> >
> > git send-email should handle those ?
>
> I'm not too familiar with git send-email, but they're not in the CC list
> of the actual e-mail.
>
> >>> +# In case we want to avoid the CPU support code, we need to define
> >>> this: +ifndef CONFIG_SPL_NO_CPU_SUPPORT_CODE
> >>> +SPL_CPU_SUPPORT_CODE := y
> >>> +endif
> >>
> >> SPL should ideally contain nothing by default. Have options that say
> >> what you do want to pull in, not what you don't want.
> >
> > You usually DO want to pull this in (because it contains vectoring code,
> > really basic lowlevel init etc), there are only border cases where you
> > do not want to do that and use your own.
>
> Sorry, I was a bit confused by seeing lib$(CPU), thought at first you
> were trying to pull in stuff like arch/$(ARCH)/lib.
>
> Still, this seems hackish. Shouldn't the control be on specific files
> that you include, not directories?

I don't think so ... why ?

>
> -Scott