[U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c

Marek Vasut
2011-10-18T09:52:20Z

> Dear Marek Vasut,
>
> In message <1317819115-9089-1-git-send-email-marek.vasut@gmail.com> you
> wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > drivers/pcmcia/tqm8xx_pcmcia.c |? 154
> > +++++++++++++++++++++------------------- 1 files changed, 81
> > insertions(+), 73 deletions(-)
>
> This commit causes new warnings on the virtlab2 board:
>
> Configuring for virtlab2 board...
> tqm8xx_pcmcia.c: In function 'power_off':
> tqm8xx_pcmcia.c:46: warning: passing argument 1 of 'out_be32' makes
> pointer from integer without a cast tqm8xx_pcmcia.c: In function
> 'power_on_5_0': tqm8xx_pcmcia.c:52: warning: passing argument 1 of
> 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In
> function 'power_on_3_3': tqm8xx_pcmcia.c:58: warning: passing argument 1
> of 'out_be32' makes pointer from integer without a cast
>
>
> Why did you not run MAKEALL???
>
> Please fix!
>
> Best regards,
>
> Wolfgang Denk

Fix for this is in my patchqueue for a while now. I'm still hunting down those +/- four byte growths/decreases though. I suspect the fact that such things happens is because the optimization graph is too complicated and gcc4.2 can't cope with it anymore.