public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP
Date: Thu, 06 Oct 2011 23:21:53 +0200	[thread overview]
Message-ID: <20111006212153.E8AC01408751@gemini.denx.de> (raw)
In-Reply-To: <1316977237-8709-1-git-send-email-marek.vasut@gmail.com>

Dear Marek Vasut,

In message <1316977237-8709-1-git-send-email-marek.vasut@gmail.com> you wrote:
> This allows the keyboard to avoid requests via Interrupt Endpoint altogether and
> run all requests via Control Endpoint. This uses the Get_Report request.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Remy Bohmer <linux@bohmer.net>
> ---
>  common/usb_kbd.c |   64 ++++++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 50 insertions(+), 14 deletions(-)
> 
> V2: Add missing condition to ignore repetitive events when polling via EP0

Checkpatch says:

total: 5 errors, 1 warnings, 97 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The following statement is not true.  The previous statement is true.

  reply	other threads:[~2011-10-06 21:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-25 18:45 [U-Boot] [PATCH] USB: Add functionality to poll the USB keyboard via control EP Marek Vasut
2011-09-25 19:00 ` [U-Boot] [PATCH V2] " Marek Vasut
2011-10-06 21:21   ` Wolfgang Denk [this message]
2011-10-06 23:31     ` Marek Vasut
2011-10-07  6:15       ` Wolfgang Denk
2011-10-08 18:32         ` Remy Bohmer
2011-10-08 18:33     ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111006212153.E8AC01408751@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox