From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c
Date: Fri, 07 Oct 2011 00:00:41 +0200 [thread overview]
Message-ID: <20111006220041.401681408751@gemini.denx.de> (raw)
In-Reply-To: <1313029189-18536-5-git-send-email-hong.xu@atmel.com>
Dear Hong Xu,
In message <1313029189-18536-5-git-send-email-hong.xu@atmel.com> you wrote:
> arch/arm/lib/cache.c is cleaned and no real cache operation will be
> defined in this file. So a new file arch/arm/cpu/arm1136/cache.c is
> created. This file will define the real cache operations.
>
> Signed-off-by: Hong Xu <hong.xu@atmel.com>
> Tested-by: Elen Song <elen.song@atmel.com>
> CC: Albert Aribaud <albert.u.boot@aribaud.net>
> CC: Aneesh V <aneesh@ti.com>
> CC: Marek Vasut <marek.vasut@gmail.com>
> CC: Reinhard Meyer <u-boot@emk-elektronik.de>
> CC: Heiko Schocher <hs@denx.de>
> ---
> arch/arm/cpu/arm1136/Makefile | 2 +-
> arch/arm/cpu/arm1136/cache.c | 33 +++++++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+), 1 deletions(-)
> create mode 100644 arch/arm/cpu/arm1136/cache.c
Checkpatch says:
WARNING: externs should be avoided in .c files
#143: FILE: arch/arm/cpu/arm1136/cache.c:29:
+ void arm1136_cache_flush(void);
Please clean up and resubmit. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, "The City on the Edge of Forever", stardate 3134.0
next prev parent reply other threads:[~2011-10-06 22:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 2:19 [U-Boot] [PATCH 0/3] ARM: Clean arm/lib/cache.c, modify ARM1136 and ARM926 accordingly Hong Xu
2011-08-11 2:19 ` [U-Boot] [PATCH 1/3] ARM: Clean arch/arm/lib/cache.c Hong Xu
2011-08-11 2:19 ` Hong Xu
2011-08-11 4:38 ` Marek Vasut
2011-08-15 7:00 ` Hong Xu
2011-08-15 8:08 ` Marek Vasut
2011-08-11 2:19 ` [U-Boot] [PATCH 2/3] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c Hong Xu
2011-08-11 2:19 ` Hong Xu
2011-08-11 4:40 ` Marek Vasut
2011-08-15 7:04 ` Hong Xu
2011-08-15 8:09 ` Marek Vasut
2011-10-06 22:00 ` Wolfgang Denk [this message]
2011-08-11 2:19 ` [U-Boot] [PATCH 3/3] ARM: ARM926EJS - Add cache operations Hong Xu
2011-08-11 2:19 ` Hong Xu
2011-08-11 4:35 ` [U-Boot] [PATCH 0/3] ARM: Clean arm/lib/cache.c, modify ARM1136 and ARM926 accordingly Marek Vasut
2011-08-18 10:51 ` Marek Vasut
2011-08-19 8:39 ` Hong Xu
2011-08-19 9:33 ` Marek Vasut
2011-10-21 20:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006220041.401681408751@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox