From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Fri, 7 Oct 2011 00:14:27 +0200
Subject: [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx
In-Reply-To: <1317807819-17056-9-git-send-email-sbabic@denx.de>
References: <1317807819-17056-1-git-send-email-sbabic@denx.de>
	<1317807819-17056-9-git-send-email-sbabic@denx.de>
Message-ID: <20111007001427.5d578407@wker>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

On Wed,  5 Oct 2011 11:43:36 +0200
Stefano Babic <sbabic@denx.de> wrote:

> The patch is a port of the Linux driver da8xx-fb.c used
> on davinci da8xx and OMAP-L138 boards.
> 
> Last commit seen on this driver used as base
> for porting is 1db41e032d563eb47deab40dc5595be306b143ba
> (video: da8xx-fb: fix section mismatch warning)
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Sandeep Paulraj <s-paulraj@ti.com>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
>  arch/arm/include/asm/arch-davinci/da8xx-fb.h |  122 ++++
>  drivers/video/Makefile                       |    1 +
>  drivers/video/da8xx-fb.c                     |  846 ++++++++++++++++++++++++++
>  3 files changed, 969 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-davinci/da8xx-fb.h
>  create mode 100644 drivers/video/da8xx-fb.c
> 
> diff --git a/arch/arm/include/asm/arch-davinci/da8xx-fb.h b/arch/arm/include/asm/arch-davinci/da8xx-fb.h
> new file mode 100644
> index 0000000..88613a5
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-davinci/da8xx-fb.h
> @@ -0,0 +1,122 @@
> +/*
> + * Header file for TI DA8XX LCD controller platform data.
> + *
> + * Copyright (C) 2008-2009 MontaVista Software Inc.
> + * Copyright (C) 2008-2009 Texas Instruments Inc
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2. This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */

Hmm, the whole driver is under GPL v2 or any later version, but this
header under GPL v2 only? Actually this doesn't make sense. Newly added
code should use GPLv3-compatible licensing, e.g. GPL v2 or any later version.

...
> +#if 0
> +/* ioctls */
> +#define FBIOGET_CONTRAST	_IOR('F', 1, int)
> +#define FBIOPUT_CONTRAST	_IOW('F', 2, int)
> +#define FBIGET_BRIGHTNESS	_IOR('F', 3, int)
> +#define FBIPUT_BRIGHTNESS	_IOW('F', 3, int)
> +#define FBIGET_COLOR		_IOR('F', 5, int)
> +#define FBIPUT_COLOR		_IOW('F', 6, int)
> +#define FBIPUT_HSYNC		_IOW('F', 9, int)
> +#define FBIPUT_VSYNC		_IOW('F', 10, int)
> +#endif

Please do not add dead code.

Thanks,
Anatolij