public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI
Date: Fri, 7 Oct 2011 01:30:14 +0200	[thread overview]
Message-ID: <201110070130.14881.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111006212114.B19601408751@gemini.denx.de>

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1316977676-10284-1-git-send-email-marek.vasut@gmail.com> you 
wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Remy Bohmer <linux@bohmer.net>
> > ---
> > 
> >  drivers/usb/host/ehci-hcd.c |   33 ++++++++++++++++++++++++++++++++-
> >  1 files changed, 32 insertions(+), 1 deletions(-)
> > 
> > V2: Drop redundant bogus header.
> 
> Checkpatch says:
> 
> total: 0 errors, 1 warnings, 43 lines checked
> 
> Please clean up and resubmit.  Thanks.
> 
> Best regards,
> 
> Wolfgang Denk

The extern-stuff checkpatch is complaining about is a problem with usbkbd.c . 
The file needs cleanup, badly, only then we can get rid of those externs.

I'd prefer to get this applied and then cleanup the usbkbd.c. The musb driver 
suffers the same trouble, so it can be cleaned up with this together.

Cheers

  reply	other threads:[~2011-10-06 23:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 15:36 [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI Marek Vasut
2011-09-24 16:41 ` Remy Bohmer
2011-09-24 16:50   ` Marek Vasut
2011-09-24 16:56     ` Remy Bohmer
2011-09-25 19:07 ` [U-Boot] [PATCH V2] " Marek Vasut
2011-10-06 21:21   ` Wolfgang Denk
2011-10-06 23:30     ` Marek Vasut [this message]
2011-10-07  5:25       ` Wolfgang Denk
2011-10-07  8:55         ` Marek Vasut
2011-10-08 18:27           ` Remy Bohmer
2011-10-08 18:28   ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110070130.14881.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox