From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 7 Oct 2011 01:30:14 +0200 Subject: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI In-Reply-To: <20111006212114.B19601408751@gemini.denx.de> References: <1316792213-18385-1-git-send-email-marek.vasut@gmail.com> <1316977676-10284-1-git-send-email-marek.vasut@gmail.com> <20111006212114.B19601408751@gemini.denx.de> Message-ID: <201110070130.14881.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1316977676-10284-1-git-send-email-marek.vasut@gmail.com> you wrote: > > Signed-off-by: Marek Vasut > > Cc: Remy Bohmer > > --- > > > > drivers/usb/host/ehci-hcd.c | 33 ++++++++++++++++++++++++++++++++- > > 1 files changed, 32 insertions(+), 1 deletions(-) > > > > V2: Drop redundant bogus header. > > Checkpatch says: > > total: 0 errors, 1 warnings, 43 lines checked > > Please clean up and resubmit. Thanks. > > Best regards, > > Wolfgang Denk The extern-stuff checkpatch is complaining about is a problem with usbkbd.c . The file needs cleanup, badly, only then we can get rid of those externs. I'd prefer to get this applied and then cleanup the usbkbd.c. The musb driver suffers the same trouble, so it can be cleaned up with this together. Cheers