From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 7 Oct 2011 01:31:53 +0200 Subject: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP In-Reply-To: <20111006212153.E8AC01408751@gemini.denx.de> References: <1316976340-31467-1-git-send-email-marek.vasut@gmail.com> <1316977237-8709-1-git-send-email-marek.vasut@gmail.com> <20111006212153.E8AC01408751@gemini.denx.de> Message-ID: <201110070131.53775.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1316977237-8709-1-git-send-email-marek.vasut@gmail.com> you wrote: > > This allows the keyboard to avoid requests via Interrupt Endpoint > > altogether and run all requests via Control Endpoint. This uses the > > Get_Report request. > > > > Signed-off-by: Marek Vasut > > Cc: Remy Bohmer > > --- > > > > common/usb_kbd.c | 64 > > ++++++++++++++++++++++++++++++++++++++++++----------- 1 files changed, > > 50 insertions(+), 14 deletions(-) > > > > V2: Add missing condition to ignore repetitive events when polling via > > EP0 > > Checkpatch says: > > total: 5 errors, 1 warnings, 97 lines checked > > Please clean up and resubmit. Thanks. > > Best regards, > > Wolfgang Denk Please see my previous comment about the state of usbkbd.c. The warnings are from original code that was moved around. I'd prefer to submit further usbkbd cleanup patch. Cheers