From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI
Date: Fri, 07 Oct 2011 07:25:22 +0200 [thread overview]
Message-ID: <20111007052522.5F96C1408752@gemini.denx.de> (raw)
In-Reply-To: <201110070130.14881.marek.vasut@gmail.com>
Dear Marek Vasut,
In message <201110070130.14881.marek.vasut@gmail.com> you wrote:
>
> > Checkpatch says:
> >
> > total: 0 errors, 1 warnings, 43 lines checked
> >
> > Please clean up and resubmit. Thanks.
...
> The extern-stuff checkpatch is complaining about is a problem with usbkbd.c .
> The file needs cleanup, badly, only then we can get rid of those externs.
>
> I'd prefer to get this applied and then cleanup the usbkbd.c. The musb driver
> suffers the same trouble, so it can be cleaned up with this together.
If Remy accepts this, I'm fine with it, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When it is incorrect, it is, at least *authoritatively* incorrect.
- Hitchiker's Guide To The Galaxy
next prev parent reply other threads:[~2011-10-07 5:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 15:36 [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI Marek Vasut
2011-09-24 16:41 ` Remy Bohmer
2011-09-24 16:50 ` Marek Vasut
2011-09-24 16:56 ` Remy Bohmer
2011-09-25 19:07 ` [U-Boot] [PATCH V2] " Marek Vasut
2011-10-06 21:21 ` Wolfgang Denk
2011-10-06 23:30 ` Marek Vasut
2011-10-07 5:25 ` Wolfgang Denk [this message]
2011-10-07 8:55 ` Marek Vasut
2011-10-08 18:27 ` Remy Bohmer
2011-10-08 18:28 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007052522.5F96C1408752@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox