From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation
Date: Fri, 07 Oct 2011 09:39:50 +0200 [thread overview]
Message-ID: <20111007093950.17d94287@lmajewski.digital.local> (raw)
In-Reply-To: <20111006221048.39BEC140874A@gemini.denx.de>
On Fri, 07 Oct 2011 00:10:48 +0200
Wolfgang Denk <wd@denx.de> wrote:
> Dear Lukasz Majewski,
>
> In message <1310567392-29082-2-git-send-email-l.majewski@samsung.com>
> you wrote:
> > This commit provides UDC driver support for Samsung's SoC
> > family of processors.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > Cc: Remy Bohmer <linux@bohmer.net>
> >
> > ---
> > Changes for v2:
> > - Coding cleanups and fixes
> > - s3c_udc* files history and origination added
> > - regs-otg.h rewritten to use structs instedad of
> > #defines
> > ---
> > drivers/usb/gadget/Makefile | 6 +-
> > drivers/usb/gadget/regs-otg.h | 209 +++++
> > drivers/usb/gadget/s3c_udc_otg.c | 892 ++++++++++++++++++
> > drivers/usb/gadget/s3c_udc_otg_xfer_dma.c | 1419
> > +++++++++++++++++++++++++++++
> > include/usb/lin_gadget_compat.h | 66 ++
> > include/usb/s3c_udc.h | 160 ++++ 6 files
> > changed, 2749 insertions(+), 3 deletions(-) create mode 100644
> > drivers/usb/gadget/regs-otg.h create mode 100644
> > drivers/usb/gadget/s3c_udc_otg.c create mode 100644
> > drivers/usb/gadget/s3c_udc_otg_xfer_dma.c create mode 100644
> > include/usb/lin_gadget_compat.h create mode 100644
> > include/usb/s3c_udc.h
>
> Checkpatch says:
>
> total: 0 errors, 16 warnings, 2758 lines checked
>
> Please clean up and resubmit. Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
Hi Wolfgang,
I've run the checkpatch from 3.1 Linux Kernel.
Output can be seen at:
http://pastebin.com/KjAKUhx0
Most warnings are related to lines over 80 characters.
This code is a debug code. As fair as I remember debug print code shall
not be break in Linux kernel for easier debugging.
I don't know what is the policy in u-boot. I haven't seen any guideline
about breaking debug code when it is larger than 80 characters (so I
stick to kernel policy).
Other warnings are related to kernel API (like the min() macro usage)
which is different in u-boot.
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center
Platform Group
next prev parent reply other threads:[~2011-10-07 7:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 14:29 [U-Boot] [PATCH v2 0/5] usb:gadget USB Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation Lukasz Majewski
2011-07-13 14:43 ` Vitaly Kuzmichev
2011-07-14 8:14 ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-10-06 22:10 ` [U-Boot] [PATCH " Wolfgang Denk
2011-10-07 7:39 ` Lukasz Majewski [this message]
2011-10-09 19:43 ` Wolfgang Denk
2011-10-10 20:00 ` Scott Wood
2011-10-10 20:38 ` Wolfgang Denk
2011-10-10 20:55 ` Scott Wood
2011-10-10 21:54 ` Wolfgang Denk
2011-10-10 22:00 ` Scott Wood
2011-07-13 14:29 ` [U-Boot] [PATCH v2 2/5] usb:gadget:s5p Enabling the USB Gadget framework at GONI Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel Lukasz Majewski
2011-10-06 22:10 ` Wolfgang Denk
2011-10-07 7:28 ` Lukasz Majewski
2011-10-07 8:25 ` Wolfgang Denk
2011-07-13 14:29 ` [U-Boot] [PATCH v2 4/5] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 5/5] usb:gadget:s5p Support for USB Mass Storage Gadget on GONI Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007093950.17d94287@lmajewski.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox