From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 7 Oct 2011 21:08:36 -0400 Subject: [U-Boot] [PATCH v2] netconsole: support packets longer than 512 bytes In-Reply-To: <201110080122.22385.michael@walle.cc> References: <1318026470-21476-1-git-send-email-michael@walle.cc> <201110071853.14032.vapier@gentoo.org> <201110080122.22385.michael@walle.cc> Message-ID: <201110072108.36852.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 07 October 2011 19:22:22 Michael Walle wrote: > Am Samstag 08 Oktober 2011, 00:53:13 schrieb Mike Frysinger: > > On Friday 07 October 2011 18:27:50 Michael Walle wrote: > > > Esp. while printing the environment the output is usually longer than > > > 512 bytes. Instead of cutting the message, send multiple 512 bytes > > > packets. > > > > sorry, i probably should have looked closer earlier. this isn't really > > your fault, but i'm guessing this 512 limit is due to the size of the > > static input_buffer ? if so, let's use sizeof(input_buffer) instead of > > 512. or add a define at the top like NETCONSOLE_BUFFER_SIZE and use that > > everywhere. > > i don't think the input buffer has sth to do with the output. of course it > could be intended, that the input buffer has the same size as the max > output size. if i didn't miss sth, the output size is only limited by the > maximum packet size (minus headers) defined by PKTSIZE. > > I don't know why the input buffer and max output size has this particular > size. Well, the input buffer could be some arbitrary number to. not too big > to save some space :) > > The max output size should be PKTSIZE-NetEthHdrSize()-IP_HDR_SIZE. yeah, i think you're right. best to keep the 512 for now until someone gets up the courage to look it over. Acked-by: Mike Frysinger -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/0aa58bc0/attachment.pgp