From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: add ide initialization
Date: Fri, 7 Oct 2011 23:50:20 +0200 [thread overview]
Message-ID: <201110072350.20528.michael@walle.cc> (raw)
In-Reply-To: <201110071327.12220.vapier@gentoo.org>
Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:
> On Thursday 06 October 2011 18:23:06 Michael Walle wrote:
> > --- a/arch/arm/lib/board.c
> > +++ b/arch/arm/lib/board.c
> >
> > +#if defined(CONFIG_CMD_IDE)
> > + puts ("IDE: ");
> > + ide_init ();
> > +#endif
>
> NAK: no space before that open paren
> -mike
as long as the style is the only objection, i'm glad to resend a fixed patch
:)
Albert, are there any other objections?
--
Michael
next prev parent reply other threads:[~2011-10-07 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 22:23 [U-Boot] [PATCH] arm: add ide initialization Michael Walle
2011-10-07 17:27 ` Mike Frysinger
2011-10-07 21:50 ` Michael Walle [this message]
2011-10-18 21:42 ` Albert ARIBAUD
2011-10-18 22:19 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110072350.20528.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox