From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] netconsole: support packets longer than 512 bytes
Date: Sat, 8 Oct 2011 01:22:22 +0200 [thread overview]
Message-ID: <201110080122.22385.michael@walle.cc> (raw)
In-Reply-To: <201110071853.14032.vapier@gentoo.org>
Am Samstag 08 Oktober 2011, 00:53:13 schrieb Mike Frysinger:
> On Friday 07 October 2011 18:27:50 Michael Walle wrote:
> > Esp. while printing the environment the output is usually longer than 512
> > bytes. Instead of cutting the message, send multiple 512 bytes packets.
>
> sorry, i probably should have looked closer earlier. this isn't really
> your fault, but i'm guessing this 512 limit is due to the size of the
> static input_buffer ? if so, let's use sizeof(input_buffer) instead of
> 512. or add a define at the top like NETCONSOLE_BUFFER_SIZE and use that
> everywhere. -mike
i don't think the input buffer has sth to do with the output. of course it
could be intended, that the input buffer has the same size as the max output
size. if i didn't miss sth, the output size is only limited by the maximum
packet size (minus headers) defined by PKTSIZE.
I don't know why the input buffer and max output size has this particular
size. Well, the input buffer could be some arbitrary number to. not too big to
save some space :)
The max output size should be PKTSIZE-NetEthHdrSize()-IP_HDR_SIZE.
--
Michael
next prev parent reply other threads:[~2011-10-07 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:27 [U-Boot] [PATCH v2] netconsole: support packets longer than 512 bytes Michael Walle
2011-10-07 22:53 ` Mike Frysinger
2011-10-07 23:22 ` Michael Walle [this message]
2011-10-08 1:08 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110080122.22385.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox