From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 8 Oct 2011 21:21:17 +0200 Subject: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver In-Reply-To: <201110081506.31839.vapier@gentoo.org> References: <1317990657-17214-1-git-send-email-marek.vasut@gmail.com> <201110072210.11734.marek.vasut@gmail.com> <201110081506.31839.vapier@gentoo.org> Message-ID: <201110082121.17758.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote: > On Friday 07 October 2011 16:10:11 Marek Vasut wrote: > > On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: > > > On Friday 07 October 2011 08:30:55 Marek Vasut wrote: > > > > Also, fix usb drivers which use extern new. > > > > > > this summary/changelog is lacking in information as to what you > > > actually did and why ... > > > > Hi Mike, generally shuffling with code, abstracting out some things, > > making it checkpatch-comformant. Also, addition of generic key report > > code when polling. > > it's hard to evaluate each piece by itself when it's just one patch > smooshing it all together > -mike Well how would you rework crap code piece by piece? Cheers