From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver
Date: Sun, 9 Oct 2011 15:13:58 +0200 [thread overview]
Message-ID: <201110091513.59466.marek.vasut@gmail.com> (raw)
In-Reply-To: <CANqCtQJCQLxg-UjOej702e2Z+OccTyE1T=JDiRN_iofHs60hgQ@mail.gmail.com>
On Sunday, October 09, 2011 11:01:36 AM Remy Bohmer wrote:
> Hi Marek,
>
> >> > > it's hard to evaluate each piece by itself when it's just one patch
> >> > > smooshing it all together
> >> >
> >> > Well how would you rework crap code piece by piece?
> >>
> >> - fix style
> >> - abstract out stuff
> >
> > Not like there was so much abstraction it couldn't be squashed into this
> > one.
> >
> >> - add new generic key support
> >
> > True, this could be separated out. Well, Remy ... what do you think?
>
> A patch that fixes style issues should _only_ fix style issues. It
> should not contain any functional change. This makes it all easier to
> review. Not only for me, but for everyone else as well.
That I understand, but I started the rework with properly passing the keyboard
data in mind. That got me to a point where I had to change most of the code,
including fixing some of the usb host drivers (because they used that extern
new;). And from that point, it was pointless to try keeping it separate.
btw Mike, I was wrong, the generic key support can't be separated out, it must
be there because you can't access the extern new anymore.
Cheers
>
> Kind regards,
>
> Remy
next prev parent reply other threads:[~2011-10-09 13:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 12:30 [U-Boot] [PATCH 0/2] USB keyboard driver rework Marek Vasut
2011-10-07 12:30 ` [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver Marek Vasut
2011-10-07 17:38 ` Mike Frysinger
2011-10-07 20:10 ` Marek Vasut
2011-10-08 19:06 ` Mike Frysinger
2011-10-08 19:21 ` Marek Vasut
2011-10-08 21:18 ` Mike Frysinger
2011-10-08 23:24 ` Marek Vasut
2011-10-09 9:01 ` Remy Bohmer
2011-10-09 13:13 ` Marek Vasut [this message]
2011-10-08 19:05 ` Mike Frysinger
2011-10-08 19:21 ` Marek Vasut
2011-10-08 21:17 ` Mike Frysinger
2011-10-09 18:54 ` Wolfgang Denk
2011-10-09 19:12 ` Marek Vasut
2011-10-09 20:15 ` Wolfgang Denk
2011-10-07 12:30 ` [U-Boot] [PATCH 2/2] USB: Drop dead code from usb_kbd.c Marek Vasut
2011-10-08 18:31 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110091513.59466.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox