From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 9 Oct 2011 15:13:58 +0200 Subject: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver In-Reply-To: References: <1317990657-17214-1-git-send-email-marek.vasut@gmail.com> <201110090124.13440.marek.vasut@gmail.com> Message-ID: <201110091513.59466.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday, October 09, 2011 11:01:36 AM Remy Bohmer wrote: > Hi Marek, > > >> > > it's hard to evaluate each piece by itself when it's just one patch > >> > > smooshing it all together > >> > > >> > Well how would you rework crap code piece by piece? > >> > >> - fix style > >> - abstract out stuff > > > > Not like there was so much abstraction it couldn't be squashed into this > > one. > > > >> - add new generic key support > > > > True, this could be separated out. Well, Remy ... what do you think? > > A patch that fixes style issues should _only_ fix style issues. It > should not contain any functional change. This makes it all easier to > review. Not only for me, but for everyone else as well. That I understand, but I started the rework with properly passing the keyboard data in mind. That got me to a point where I had to change most of the code, including fixing some of the usb host drivers (because they used that extern new;). And from that point, it was pointless to try keeping it separate. btw Mike, I was wrong, the generic key support can't be separated out, it must be there because you can't access the extern new anymore. Cheers > > Kind regards, > > Remy