From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver
Date: Sun, 9 Oct 2011 21:12:17 +0200 [thread overview]
Message-ID: <201110092112.18014.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111009185407.745D91408753@gemini.denx.de>
On Sunday, October 09, 2011 08:54:07 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
>
> In message <1317990657-17214-2-git-send-email-marek.vasut@gmail.com> you
wrote:
> > Also, fix usb drivers which use extern new.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > Cc: Bryan Wu <bryan.wu@analog.com>
> > Cc: Cliff Cai <cliff.cai@analog.com>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> > Cc: Remy Bohmer <linux@bohmer.net>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> >
> > common/usb_kbd.c | 644
> > ++++++++++++++++++++++++------------------- drivers/usb/host/ehci-hcd.c
> > | 20 +--
> > drivers/usb/musb/musb_hcd.c | 19 +--
> > include/usb.h | 1 +
> > 4 files changed, 369 insertions(+), 315 deletions(-)
> >
> > NOTE: Tested on EfikaSB device, but please test on some more hardware
> > first!
> >
> > diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> > index 503d175..d19551b 100644
> > --- a/common/usb_kbd.c
> > +++ b/common/usb_kbd.c
> > @@ -25,402 +25,490 @@
> >
> > *
> > */
> >
> > #include <common.h>
> >
> > +#include <malloc.h>
> >
> > #include <stdio_dev.h>
> > #include <asm/byteorder.h>
> >
> > #include <usb.h>
> >
> > -#undef USB_KBD_DEBUG
> > +/* USB Keyboard Debug */
> > +#undef USB_KBD_DEBUG
>
> Please do not undef what is not defined [or what a user might want to
> define on the command line].
Command line ? This is a placeholder in case the user wants to debug this piece
of code.
>
> > +/* Keyboard sampling rate */
> > +#define REPEAT_RATE (40 / 4) /* 40msec -> 25cps */
> > +#define REPEAT_DELAY 10 /* 10 x REAPEAT_RATE = 400msec
*/
>
> Please fix the typo while you are at it.
True.
>
> And please split code changes and pure cosmetic ones into separate
> commits. Thanks.
Well that means I can do all this work one more time :-( I'll get to it
sometimes ... later.
Cheers
>
> Best regards,
>
> Wolfgang Denk
next prev parent reply other threads:[~2011-10-09 19:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 12:30 [U-Boot] [PATCH 0/2] USB keyboard driver rework Marek Vasut
2011-10-07 12:30 ` [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver Marek Vasut
2011-10-07 17:38 ` Mike Frysinger
2011-10-07 20:10 ` Marek Vasut
2011-10-08 19:06 ` Mike Frysinger
2011-10-08 19:21 ` Marek Vasut
2011-10-08 21:18 ` Mike Frysinger
2011-10-08 23:24 ` Marek Vasut
2011-10-09 9:01 ` Remy Bohmer
2011-10-09 13:13 ` Marek Vasut
2011-10-08 19:05 ` Mike Frysinger
2011-10-08 19:21 ` Marek Vasut
2011-10-08 21:17 ` Mike Frysinger
2011-10-09 18:54 ` Wolfgang Denk
2011-10-09 19:12 ` Marek Vasut [this message]
2011-10-09 20:15 ` Wolfgang Denk
2011-10-07 12:30 ` [U-Boot] [PATCH 2/2] USB: Drop dead code from usb_kbd.c Marek Vasut
2011-10-08 18:31 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110092112.18014.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox