From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI
Date: Mon, 10 Oct 2011 11:18:04 -0400 [thread overview]
Message-ID: <201110101118.05350.vapier@gentoo.org> (raw)
In-Reply-To: <20111010125728.ED6B71408753@gemini.denx.de>
On Monday 10 October 2011 08:57:28 Wolfgang Denk wrote:
> Michal Simek wrote:
> > >> defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \
> > >> defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \
> > >> defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \
> > >> - defined(CONFIG_TEGRA2)
> > >> + defined(CONFIG_TEGRA2) || defined(CONFIG_MICROBLAZE)
> > >
> > > Am I the only one that thinks this is all really ugly?
> >
> > I hope you mean serial.h not mb code.
> >
> > I agree with you but not sure if we can remove all ifdefs there.
>
> The long list of device specific ifdef's should be converted into a
> single ifdef testing for a specific feature instead.
it's driver specific code in this file, so it doesn't make much sense to have
the board config define something just to get these prototypes
i do agree that this multi serial code is all very ugly ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111010/45ae8963/attachment.pgp
next prev parent reply other threads:[~2011-10-10 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 7:17 [U-Boot] microblaze - serial multi Michal Simek
2011-10-10 7:17 ` [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI Michal Simek
2011-10-10 10:11 ` Graeme Russ
2011-10-10 10:52 ` Michal Simek
2011-10-10 12:57 ` Wolfgang Denk
2011-10-10 15:18 ` Mike Frysinger [this message]
2011-10-10 17:35 ` Wolfgang Denk
2011-10-10 17:52 ` Mike Frysinger
2011-10-10 18:26 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2011-09-06 14:22 [U-Boot] [PATCH v2] serial: uartlite: Support for SERIAL_MULTI Michal Simek
2011-09-06 14:22 ` [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110101118.05350.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox