From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 Oct 2011 11:19:47 -0400
Subject: [U-Boot] [PATCH V3 05/13] i2c: Create common default
	i2c_set_bus_num() function
In-Reply-To: <1318243812-22928-1-git-send-email-sbabic@denx.de>
References: <1318091769-30979-1-git-send-email-sbabic@denx.de>
	<1318243812-22928-1-git-send-email-sbabic@denx.de>
Message-ID: <201110101119.48636.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 10 October 2011 06:50:12 Stefano Babic wrote:
> +int __def_i2c_set_bus_num(unsigned int bus)
> +{
> +	return 0;
> +}
> +int i2c_set_bus_num(unsigned int)
> +	__attribute__((weak, alias("__def_i2c_set_bus_num")));

any reason this can't just be:
__weak int i2c_set_bus_num(unsigned int bus)
{
	return 0;
}

i can understand having a default func when it actually does something, but i 
don't see much value in a stub that returns 0
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111010/93d9d00b/attachment.pgp