From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 10 Oct 2011 16:46:14 -0400 Subject: [U-Boot] WARNING: space prohibited between function name and open parenthesis '(' In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173B23B59F@HQMAIL01.nvidia.com> References: <74CDBE0F657A3D45AFBB94109FB122FF173B23B59F@HQMAIL01.nvidia.com> Message-ID: <201110101646.15519.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 10 October 2011 14:59:17 Stephen Warren wrote: > I'm getting a lot of the following when running checkpatch: > > WARNING: space prohibited between function name and open parenthesis '(' > > Should I ignore these? > > So far, I've written completely new code such that it doesn't trigger > this warning, but where editing existing code (e.g. just changing the > name of a function), I've avoided fixing this checkpatch warning so it's > more obvious what my diff is doing; equally, fixing this would cause the > lines I edit to be inconsistent with those around them. > > Any guidance appreciated. Thanks. you'll probably hit a bit of this for a while as there is a lot of existing/old code in u-boot which doesn't follow checkpatch :( hopefully that'll become less frequent over time -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111010/d4b19dbc/attachment.pgp