public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 09/12] VIDEO: davinci: add framebuffer to da8xx
Date: Wed, 12 Oct 2011 11:06:27 +0200	[thread overview]
Message-ID: <20111012110627.48fd0143@wker> (raw)
In-Reply-To: <4E9552ED.1060206@denx.de>

On Wed, 12 Oct 2011 10:42:21 +0200
Stefano Babic <sbabic@denx.de> wrote:

> On 10/11/2011 06:10 PM, Anatolij Gustschin wrote:
> > Hi Stefano,
> 
> Hi Anatolij,

Hi Stefano,
 
> > Thanks for these fixes. When applying this patch I see:
> > 
> > $ git am /tmp/\[PATCH\ V2\ 09_12\]\ VIDEO\:\ davinci\:\ add\ framebuffer\ to\ da8xx 
> > Applying: VIDEO: davinci: add framebuffer to da8xx
> > /home/ag/u-boot/u-boot-move-new-host/u-boot-video/.git/rebase-apply/patch:22: new blank line at EOF.
> > +
> > warning: 1 line adds whitespace errors.
> > 
> > This is due to the trailing empty line in
> > "arch/arm/include/asm/arch-davinci/da8xx-fb.h" I'think.
> > Can you please fix it also?
> 
> I have tried, no luck. I wonder that in my case I get a different line
> for error:
> 
> /home/stefano/Projects/imx/u-boot-imx/.git/rebase-apply/patch:14: new
> blank line at EOF.
> 
> Removing the empty line and the newline after the GIT version at the end
> of the file makes no change - I still get this error.
> 
> "new blank line" suggets me that it is something after the patch itself,
> but I have no idea where I should check. The patch seems correct. With
> "git am --whitespace=fix", the patch is applied, but there is no other
> hints about this issue.

git am complains since there is a blank line at the end of the
added arch/arm/include/asm/arch-davinci/da8xx-fb.h file.

OK, there is no need to resubmit this patch since it can be applied
with "--whitespace=fix" option.

Thanks,
Anatolij

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2011-10-12  9:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  9:43 [U-Boot] [PATCH 01/12] Davinci: ea20: set console on UART0 Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 02/12] Davinci: ea20: set GPIOs to hold MII-Phy in reset and set UART0-Switch for console Stefano Babic
2011-10-05 12:06   ` Laurence Withers
2011-10-05 13:00     ` Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 03/12] Davinci: ea20: Add NAND support Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 04/12] Davinci: ea20: Add early init to get early output from console Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 05/12] Davinci: ea20: Add default U-Boot environment Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 06/12] Davinci: ea20: add gpio for keeping power on in board_late_init Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 07/12] Davinci: ea20: add gpios for LCD backlight control Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 08/12] ARM: Davinci: added missing registers to hardware.h Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-06 22:14   ` Anatolij Gustschin
2011-10-06 22:22     ` stefano babic
2011-10-06 22:32   ` Wolfgang Denk
2011-10-06 22:44     ` stefano babic
2011-10-07  4:42       ` Wolfgang Denk
2011-10-05  9:43 ` [U-Boot] [PATCH 10/12] Davinci: ea20: added video support Stefano Babic
2011-10-06 21:12   ` Anatolij Gustschin
2011-10-05  9:43 ` [U-Boot] [PATCH 11/12] Davinci: ea20: added I2C support Stefano Babic
2011-10-05  9:43 ` [U-Boot] [PATCH 12/12] Davinci: ea20: added PREBOOT to configuration Stefano Babic
2011-10-05 13:08 ` [U-Boot] [PATCH 13/13] Davinci: ea20: use gpio framework to access gpios Stefano Babic
2011-10-05 13:14   ` Laurence Withers
2011-10-05 13:49     ` Stefano Babic
2011-10-08  9:27 ` [U-Boot] [PATCH V2 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-11 16:10   ` Anatolij Gustschin
2011-10-12  8:42     ` Stefano Babic
2011-10-12  9:06       ` Anatolij Gustschin [this message]
2011-10-12  9:35         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012110627.48fd0143@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox