From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 12 Oct 2011 11:55:54 +0200
Subject: [U-Boot] [PATCH v2] ppc4xx: Add Io64 board support
In-Reply-To: <1318343585-3434-1-git-send-email-eibach@gdsys.de>
References: <1318343585-3434-1-git-send-email-eibach@gdsys.de>
Message-ID: <201110121155.54936.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dirk,

On Tuesday 11 October 2011 16:33:05 eibach at gdsys.de wrote:
> diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c
> index 9885b14..1be0a34 100644
> --- a/arch/powerpc/lib/board.c
> +++ b/arch/powerpc/lib/board.c
> @@ -130,6 +130,10 @@ ulong monitor_flash_len;
>  #include <bedbug/type.h>
>  #endif
> 
> +#ifdef CONFIG_SYS_FPGA_COUNT
> +#include <gdsys_fpga.h>
> +#endif
> +
>  /************************************************************************
>   * Utilities								
*
>   ************************************************************************
> @@ -322,6 +326,9 @@ init_fnc_t *init_sequence[] = {
>  #ifdef CONFIG_POST
>  	post_init_f,
>  #endif
> +#ifdef CONFIG_FPGA_INIT
> +	init_func_fpga,
> +#endif

Do you really need to add this to this common code? Can't you move this to 
some early board specific function? We really shouldn't add more board 
specific code here.

Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de