From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] checkpatch compliance
Date: Thu, 13 Oct 2011 14:19:34 -0400 [thread overview]
Message-ID: <201110131419.35526.vapier@gentoo.org> (raw)
In-Reply-To: <CANr=Z=bPOpCWcMX5NL+=y1JQPZNaqRczimWi8hZ=L-043FNkWw@mail.gmail.com>
On Thursday 13 October 2011 13:14:34 Joe Hershberger wrote:
> On Wed, Oct 12, 2011 at 8:03 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Wednesday 12 October 2011 20:56:09 Joe Hershberger wrote:
> >> WARNING:NEW_TYPEDEFS: do not add new typedefs
> >> This seems rather limiting... I'm not sure why even Linux would want
> >> this, at least when it applies to typedefs of structs. It makes sense
> >> if it's a new typedef for int or something.
> >
> > Linux has been discouraging new struct typedefs. but it is too broad and
> > catches typedefs that we want (like posix_types.h).
>
> So it's a candidate to ignore, right?
it's like the volatiles check. reviewed on a case by case basis.
> >> WARNING:VOLATILE: Use of volatile is usually wrong: see
> >> Documentation/volatile-considered-harmful.txt
> >> Sometimes using volatile is correct... not sure how this fits in with
> >> a policy of 0 errors and 0 warnings... Should it be ignored or not?
> >
> > "it depends". we'll have to see the specific instance.
>
> That's what I was getting at... should we ignore it in checkpatch and
> simply review any new volatile variables?
if checkpatch ignores it, people won't notice
> Or should we not ignore it in checkpatch and have exceptions to "no errors,
> no warnings"?
i've always advocated not using checkpatch this way. it's simply another tool
which has known bugs and doesn't cover realistic nuances.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/41b307a0/attachment.pgp
next prev parent reply other threads:[~2011-10-13 18:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:28 [U-Boot] checkpatch compliance Joe Hershberger
2011-10-09 19:22 ` Wolfgang Denk
2011-10-12 1:41 ` [U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools Joe Hershberger
2011-10-13 2:54 ` Xiangfu Liu
2011-10-13 3:27 ` Mike Frysinger
2011-10-13 17:25 ` Joe Hershberger
2011-10-13 18:20 ` Mike Frysinger
2011-10-13 18:30 ` Joe Hershberger
2011-10-13 19:01 ` Mike Frysinger
2011-10-18 20:06 ` [U-Boot] [PATCH v2] " Joe Hershberger
2011-10-19 18:28 ` Joe Hershberger
2011-11-17 13:28 ` Wolfgang Denk
2011-10-12 1:42 ` [U-Boot] checkpatch compliance Joe Hershberger
2011-10-12 3:59 ` Mike Frysinger
2011-10-12 7:36 ` Wolfgang Denk
2011-10-12 17:57 ` Mike Frysinger
2011-10-12 18:41 ` Wolfgang Denk
2011-10-12 19:24 ` Mike Frysinger
2011-10-13 23:03 ` [U-Boot] [PATCH 1/2] common: cosmetic: CONFIG_ROOTPATH " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 23:03 ` [U-Boot] [PATCH 2/2] common: cosmetic: CONFIG_BOOTFILE " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-13 22:41 ` Joe Hershberger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 0:56 ` [U-Boot] " Joe Hershberger
2011-10-13 1:03 ` Mike Frysinger
2011-10-13 17:14 ` Joe Hershberger
2011-10-13 18:19 ` Mike Frysinger [this message]
2011-10-13 20:36 ` Wolfgang Denk
2011-11-17 20:10 ` Gerlando Falauto
2011-11-17 20:54 ` Wolfgang Denk
2011-11-18 7:25 ` Gerlando Falauto
2011-11-17 21:33 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110131419.35526.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox