From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools
Date: Thu, 13 Oct 2011 15:01:52 -0400 [thread overview]
Message-ID: <201110131501.53873.vapier@gentoo.org> (raw)
In-Reply-To: <CANr=Z=Y_ace+PROffu3UmcZuF1BNMzqEqrLB9KdS1r9Koi1fSw@mail.gmail.com>
On Thursday 13 October 2011 14:30:12 Joe Hershberger wrote:
> On Thu, Oct 13, 2011 at 1:20 PM, Mike Frysinger wrote:
> > On Thursday 13 October 2011 13:25:51 Joe Hershberger wrote:
> >> On Wed, Oct 12, 2011 at 10:27 PM, Mike Frysinger wrote:
> >> > On Tuesday 11 October 2011 21:41:19 Joe Hershberger wrote:
> >> >> +# For Linux includes
> >> >> +--ignore ARCH_INCLUDE_LINUX
> >> >> +--ignore INCLUDE_LINUX
> >> >
> >> > i think these checks are good actually. we import headers from Linux
> >> > all the time ...
> >>
> >> These seem to be irrelevant if --no-tree is specified. It doesn't
> >> seem like checkpatch would make good decisions about this anyway given
> >> that an include file that exists in the referred-to Linux tree may not
> >> exist in the u-boot tree.
> >
> > use the u-boot tree, then it works fine
>
> With the latest version of checkpatch that does not work...
sad
> checkpatch looks for the following files/folders to identify the
> top_of_kernel_tree:
>
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> "fs", "init", "ipc", "kernel", "lib", "scripts",
>
> u-boot has no Kbuild, Documentation, init, ipc, kernel, or scripts.
i guess let's talk to lkml to see about decoupling this so that only the
required paths get checked for the relevant tests. for the header tests, that
should only require include/linux/ to exist.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/8fd38fd7/attachment.pgp
next prev parent reply other threads:[~2011-10-13 19:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:28 [U-Boot] checkpatch compliance Joe Hershberger
2011-10-09 19:22 ` Wolfgang Denk
2011-10-12 1:41 ` [U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools Joe Hershberger
2011-10-13 2:54 ` Xiangfu Liu
2011-10-13 3:27 ` Mike Frysinger
2011-10-13 17:25 ` Joe Hershberger
2011-10-13 18:20 ` Mike Frysinger
2011-10-13 18:30 ` Joe Hershberger
2011-10-13 19:01 ` Mike Frysinger [this message]
2011-10-18 20:06 ` [U-Boot] [PATCH v2] " Joe Hershberger
2011-10-19 18:28 ` Joe Hershberger
2011-11-17 13:28 ` Wolfgang Denk
2011-10-12 1:42 ` [U-Boot] checkpatch compliance Joe Hershberger
2011-10-12 3:59 ` Mike Frysinger
2011-10-12 7:36 ` Wolfgang Denk
2011-10-12 17:57 ` Mike Frysinger
2011-10-12 18:41 ` Wolfgang Denk
2011-10-12 19:24 ` Mike Frysinger
2011-10-13 23:03 ` [U-Boot] [PATCH 1/2] common: cosmetic: CONFIG_ROOTPATH " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 23:03 ` [U-Boot] [PATCH 2/2] common: cosmetic: CONFIG_BOOTFILE " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-13 22:41 ` Joe Hershberger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 0:56 ` [U-Boot] " Joe Hershberger
2011-10-13 1:03 ` Mike Frysinger
2011-10-13 17:14 ` Joe Hershberger
2011-10-13 18:19 ` Mike Frysinger
2011-10-13 20:36 ` Wolfgang Denk
2011-11-17 20:10 ` Gerlando Falauto
2011-11-17 20:54 ` Wolfgang Denk
2011-11-18 7:25 ` Gerlando Falauto
2011-11-17 21:33 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110131501.53873.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox