From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] AM35xx: add EMAC support
Date: Thu, 13 Oct 2011 18:55:58 -0400 [thread overview]
Message-ID: <201110131855.59960.vapier@gentoo.org> (raw)
In-Reply-To: <1318540312-24777-7-git-send-email-yanok@emcraft.com>
On Thursday 13 October 2011 17:11:50 Ilya Yanok wrote:
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/omap3/emac.c
>
> +/*
> + * Initializes on-chip ethernet controllers.
> + * to override, implement board_eth_init()
> + */
> +int cpu_eth_init(bd_t *bis)
> +{
> + davinci_emac_initialize();
> +
> + return 0;
> +}
shouldn't emac support always be up to the board porter and not the SoC code ?
also, this should be:
int cpu_eth_init(bd_t *bis)
{
return davinci_emac_initialize();
}
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/02c93de5/attachment.pgp
next prev parent reply other threads:[~2011-10-13 22:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 21:11 [U-Boot] [PATCH 0/8][v2] DaVinci EMAC for AM35x and HTKW mcx board support Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 1/8] davinci_emac: move arch-independent defines to separate header Ilya Yanok
2011-10-13 22:56 ` Mike Frysinger
2011-10-13 21:11 ` [U-Boot] [PATCH 2/8] davinci_emac: use internal addresses in buffer descriptors Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 3/8] davinci_emac: conditionally compile specific PHY support Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 4/8] davinci_emac: fix for running with dcache enabled Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 5/8] davinci_emac: hardcode 100Mbps for AM35xx and RMII Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 6/8] AM35xx: add EMAC support Ilya Yanok
2011-10-13 22:55 ` Mike Frysinger [this message]
2011-10-14 7:51 ` Ilya Yanok
2011-10-16 8:11 ` Igor Grinberg
2011-10-17 22:32 ` [U-Boot] [PATCH 6/8][v3] " Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 7/8] AM3517: move AM3517 specific mux defines to generic header Ilya Yanok
2011-10-16 8:15 ` Igor Grinberg
2011-10-13 21:11 ` [U-Boot] [PATCH 8/8] mcx: support for HTKW mcx board Ilya Yanok
2011-10-13 22:56 ` Mike Frysinger
2011-10-17 22:25 ` [U-Boot] [PATCH] AM35xx: add EMAC support Ilya Yanok
2011-10-17 22:28 ` Ilya Yanok
2011-10-17 22:37 ` [U-Boot] [PATCH 8/8][v3] mcx: support for HTKW mcx board Ilya Yanok
2011-10-16 8:42 ` [U-Boot] [PATCH 8/8] " Igor Grinberg
2011-10-17 22:34 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110131855.59960.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox