From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 14 Oct 2011 17:50:08 +0200 Subject: [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c In-Reply-To: <201110101445.06697.vapier@gentoo.org> References: <1318260867-5606-1-git-send-email-marek.vasut@gmail.com> <201110102033.47223.marek.vasut@gmail.com> <201110101445.06697.vapier@gentoo.org> Message-ID: <201110141750.08241.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, October 10, 2011 08:45:05 PM Mike Frysinger wrote: > On Monday 10 October 2011 14:33:47 Marek Vasut wrote: > > On Monday, October 10, 2011 08:24:48 PM Mike Frysinger wrote: > > > On Monday 10 October 2011 11:34:26 Marek Vasut wrote: > > > > --- a/common/usb_kbd.c > > > > +++ b/common/usb_kbd.c > > > > > > > > -#undef USB_KBD_DEBUG > > > > +#ifdef USB_KBD_DEBUG > > > > +#define USB_KBD_PRINTF(fmt, args...) printf(fmt, ##args) > > > > +#else > > > > +#define USB_KBD_PRINTF(fmt, args...) > > > > +#endif > > > > > > could we possibly just get rid of USB_KBD_PRINTF() altogether ? delete > > > this chunk and convert everything else to debug() ? > > > > I'll squash all these in the subsequence "gcc4.6, rework debug()" macro > > patch. > > WFM > > Acked-by: Mike Frysinger > -mike Remy, bump ?