From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] Add getenv_int() to read an integer from an environment variable
Date: Fri, 14 Oct 2011 21:29:30 +0200 [thread overview]
Message-ID: <20111014192930.D44FD14094B2@gemini.denx.de> (raw)
In-Reply-To: <1318552994-6653-2-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-2-git-send-email-sjg@chromium.org> you wrote:
>
> --- a/include/common.h
> +++ b/include/common.h
...
> +/**
> + * Decode the value of an environment variable and return it.
> + *
> + * @param name Name of environemnt variable
> + * @param base Number base to use (normally 10, or 16 for hex)
> + * @param default_val Default value to return if the variable is not
> + * found
> + * @return the decoded value, or default_val if not found
> + */
Please don't add such documentation to common.h (especially not when it
breaks the coding style for multiline comments).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Just Say No." - Nancy Reagan
"No." - Ronald Reagan
next prev parent reply other threads:[~2011-10-14 19:29 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 0:43 [U-Boot] [PATCH 0/10] Add getenv_ulong to return an environment var as a number Simon Glass
2011-10-14 0:43 ` [U-Boot] [PATCH 01/10] Add getenv_int() to read an integer from an environment variable Simon Glass
2011-10-14 1:53 ` Mike Frysinger
2011-10-14 16:47 ` Simon Glass
2011-10-14 17:09 ` Mike Frysinger
2011-10-14 17:42 ` Simon Glass
2011-10-14 18:06 ` Mike Frysinger
2011-10-14 18:15 ` Simon Glass
2011-10-14 19:29 ` Wolfgang Denk [this message]
2011-10-14 0:43 ` [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul Simon Glass
2011-10-23 20:50 ` Wolfgang Denk
2011-10-23 21:49 ` Wolfgang Denk
2011-10-24 0:19 ` Simon Glass
2011-10-23 21:51 ` [U-Boot] [PATCH] arch/arm/lib/board.c: fix build error Wolfgang Denk
2011-10-24 0:29 ` Simon Glass
2011-10-24 7:00 ` Heiko Schocher
2011-10-14 0:43 ` [U-Boot] [PATCH 03/10] avr32: Use getenv_ulong() in place of getenv(), strtoul Simon Glass
2011-10-23 20:50 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 04/10] blackfin: " Simon Glass
2011-10-14 1:54 ` Mike Frysinger
2011-10-23 20:50 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 05/10] m68k: " Simon Glass
2011-10-23 20:51 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 06/10] microblaze: " Simon Glass
2011-10-23 20:52 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 07/10] mips: " Simon Glass
2011-10-23 20:52 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 08/10] powerpc: " Simon Glass
2011-10-14 6:04 ` Stefan Roese
2011-10-23 20:53 ` Wolfgang Denk
2011-10-23 21:58 ` [U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning Wolfgang Denk
2011-10-24 3:49 ` Simon Glass
2011-10-24 6:53 ` Heiko Schocher
2011-11-03 19:09 ` Wolfgang Denk
2011-11-04 6:44 ` Kumar Gala
2011-11-04 6:47 ` Kumar Gala
2011-11-04 15:41 ` Kim Phillips
2011-11-04 21:13 ` Mike Frysinger
2011-11-04 21:34 ` [U-Boot] [PATCH] powerpc: Revert "arch/powerpc/lib/board.c: fix build warning" Kim Phillips
2011-11-05 9:33 ` Wolfgang Denk
2011-11-06 18:06 ` Mike Frysinger
2011-11-06 19:49 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 09/10] sparc: Use getenv_ulong() in place of getenv(), strtoul Simon Glass
2011-10-23 20:53 ` Wolfgang Denk
2011-10-14 0:43 ` [U-Boot] [PATCH 10/10] x86: " Simon Glass
2011-10-23 20:53 ` Wolfgang Denk
2011-10-14 6:13 ` [U-Boot] [PATCH 0/10] Add getenv_ulong to return an environment var as a number Reinhard Meyer
2011-10-14 14:31 ` Simon Glass
2011-10-14 17:11 ` Mike Frysinger
2011-10-14 19:30 ` Wolfgang Denk
2011-10-14 21:05 ` Simon Glass
2011-10-14 19:27 ` Wolfgang Denk
2011-10-14 21:33 ` Mike Frysinger
2011-10-14 23:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014192930.D44FD14094B2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox