From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 14 Oct 2011 23:06:51 +0200 Subject: [U-Boot] [PATCH 01/15 V3] iMX28: Initial support for iMX28 CPU In-Reply-To: <20111014210035.EB2C81408743@gemini.denx.de> References: <1317131135-22354-1-git-send-email-marek.vasut@gmail.com> <201110140959.42368.marek.vasut@gmail.com> <20111014210035.EB2C81408743@gemini.denx.de> Message-ID: <201110142306.51418.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, October 14, 2011 11:00:35 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201110140959.42368.marek.vasut@gmail.com> you wrote: > > > Running checkpatch on your patches I see a lot of issues, and not only > > > a couple of them. > > > > > > For example, > > > > > > WARNING: line over 80 characters > > > #632: FILE: arch/arm/cpu/arm926ejs/mx28/mx28.c:150: > > > +int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * > > > const argv[]) > > > > those iomux-mx28.h issues were already explained. It's a file taken from > > linux kernel with no modifications, that's why the issues. And if you > > take a look inside, fixing it would make it unreadable. > > The error above appears to be unrelated. Why did you not fix at least > these? I believe the V3 should have that error fixed. The line-over-80 error that is.