U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] NS16550: buffer reads
Date: Sat, 15 Oct 2011 19:55:16 +0200	[thread overview]
Message-ID: <201110151955.16625.marek.vasut@gmail.com> (raw)
In-Reply-To: <1318694632-21872-1-git-send-email-sjg@chromium.org>

On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote:
> From: Scott Wood <scottwood@freescale.com>
> 
> From: Scott Wood <scottwood@freescale.com>
> 
> This improves the performance of U-Boot when accepting rapid input,
> such as pasting a sequence of commands.

Hi Simon,

[...]

> diff --git a/include/ns16550.h b/include/ns16550.h
> index 51f1c17..60b0abc 100644
> --- a/include/ns16550.h
> +++ b/include/ns16550.h
> @@ -164,6 +164,6 @@ typedef volatile struct NS16550 *NS16550_t;
> 
>  void	NS16550_init   (NS16550_t com_port, int baud_divisor);
>  void	NS16550_putc   (NS16550_t com_port, char c);
> -char	NS16550_getc   (NS16550_t com_port);
> -int	NS16550_tstc   (NS16550_t com_port);
> +char NS16550_getc(NS16550_t regs, unsigned int port);
> +int NS16550_tstc(NS16550_t regs, unsigned int port);
>  void	NS16550_reinit (NS16550_t com_port, int baud_divisor);

Maybe you should fix the indent altogether ?

Cheers

  reply	other threads:[~2011-10-15 17:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-15 16:03 [U-Boot] [PATCH v3] NS16550: buffer reads Simon Glass
2011-10-15 17:55 ` Marek Vasut [this message]
2011-10-16  3:56   ` Simon Glass
2011-10-16  4:18     ` Marek Vasut
2011-10-16  5:11       ` Simon Glass
2011-10-15 19:08 ` Wolfgang Denk
2011-10-16  5:11   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110151955.16625.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox