From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Checkpatch warnings for "volatile"
Date: Sat, 15 Oct 2011 20:11:14 +0200 [thread overview]
Message-ID: <201110152011.14163.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111015085654.6921D1408743@gemini.denx.de>
On Saturday, October 15, 2011 10:56:54 AM Wolfgang Denk wrote:
> Dear Prabhakar Lad,
>
> In message <CA+V-a8sYRZJDZojEpQ55ZGRZ6--
Niq0ThKVV8e_RtQrRuShE8A@mail.gmail.com> you wrote:
> > > I've explained this a number of times recently - there are actually
> > > very, very few occasions where "volatile" actually makes sense.
> > >
> > > Agreed, but I see a piece of code where virtual address are
> > > compared.
> >
> > For example in arch/arm/cpu/arm926ejs/davinci/cpu.c
> > In this function static inline unsigned pll_prediv(unsigned pllbase)
> >
> > and
> >
> > also in this static inline unsigned pll_postdiv(unsigned pllbase)
> >
> > Any suggestion on this on how to tackle or let it remain stagnant?
>
> I cannot see a justification for any of the ""volatile" in this file.
>
> Of course, all these ugly REG() calls should be converted to proper
> use of I/O accessors.
Definitelly ... but I'm not swiping this one, I have enough mess on my hands
already ;-)
Cheers
prev parent reply other threads:[~2011-10-15 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 10:35 [U-Boot] Checkpatch warnings for "volatile" Prabhakar Lad
2011-10-14 9:16 ` Prabhakar Lad
2011-10-14 13:12 ` Jason
2011-10-14 19:58 ` Wolfgang Denk
2011-10-14 20:22 ` Jason
2011-10-14 21:24 ` Wolfgang Denk
2011-10-15 6:01 ` Prabhakar Lad
2011-10-15 8:56 ` Wolfgang Denk
2011-10-15 14:57 ` Prabhakar Lad
2011-10-15 18:11 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110152011.14163.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox