public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
@ 2011-10-06 22:23 Michael Walle
  2011-10-07 17:24 ` Mike Frysinger
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Michael Walle @ 2011-10-06 22:23 UTC (permalink / raw)
  To: u-boot

The spi_init() function is missing. Add it.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/spi/kirkwood_spi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a1c3070..8c35d5e 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int cs)
 }
 #endif
 
+void spi_init(void)
+{
+}
+
 void spi_cs_activate(struct spi_slave *slave)
 {
 	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-06 22:23 [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init() Michael Walle
@ 2011-10-07 17:24 ` Mike Frysinger
  2011-10-16 18:32 ` Michael Walle
  2011-10-18 11:09 ` Prafulla Wadaskar
  2 siblings, 0 replies; 7+ messages in thread
From: Mike Frysinger @ 2011-10-07 17:24 UTC (permalink / raw)
  To: u-boot

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/4dbe9099/attachment.pgp 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-06 22:23 [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init() Michael Walle
  2011-10-07 17:24 ` Mike Frysinger
@ 2011-10-16 18:32 ` Michael Walle
  2011-10-16 20:25   ` Wolfgang Denk
  2011-10-18 11:09 ` Prafulla Wadaskar
  2 siblings, 1 reply; 7+ messages in thread
From: Michael Walle @ 2011-10-16 18:32 UTC (permalink / raw)
  To: u-boot

Am Freitag 07 Oktober 2011, 00:23:54 schrieb Michael Walle:
> The spi_init() function is missing. Add it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/spi/kirkwood_spi.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index a1c3070..8c35d5e 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int cs)
>  }
>  #endif
> 
> +void spi_init(void)
> +{
> +}
> +
>  void spi_cs_activate(struct spi_slave *slave)
>  {
>  	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);

Hi Wolfgang,
could you commit this small patch? (acked by mike)

-- 
Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-16 18:32 ` Michael Walle
@ 2011-10-16 20:25   ` Wolfgang Denk
  2011-10-16 20:42     ` Michael Walle
  0 siblings, 1 reply; 7+ messages in thread
From: Wolfgang Denk @ 2011-10-16 20:25 UTC (permalink / raw)
  To: u-boot

Dear Michael Walle,

In message <201110162032.02236.michael@walle.cc> you wrote:
>
> > The spi_init() function is missing. Add it.
> > 
> > Signed-off-by: Michael Walle <michael@walle.cc>
...
> could you commit this small patch? (acked by mike)

No, I cannot.  This is kirkwood related and thus has to go through the
Marvell custodian.

You had him on Cc: ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If programming was easy, they wouldn't need something as  complicated
as a human being to do it, now would they?
                       - L. Wall & R. L. Schwartz, _Programming Perl_

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-16 20:25   ` Wolfgang Denk
@ 2011-10-16 20:42     ` Michael Walle
  2011-10-17 10:22       ` Prafulla Wadaskar
  0 siblings, 1 reply; 7+ messages in thread
From: Michael Walle @ 2011-10-16 20:42 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

Am Sonntag 16 Oktober 2011, 22:25:11 schrieb Wolfgang Denk:
> In message <201110162032.02236.michael@walle.cc> you wrote:
> > > The spi_init() function is missing. Add it.
> > > 
> > > Signed-off-by: Michael Walle <michael@walle.cc>
> 
> ...
> 
> > could you commit this small patch? (acked by mike)
> 
> No, I cannot.  This is kirkwood related and thus has to go through the
> Marvell custodian.
oh sorry :)

> You had him on Cc: ?
No, but now.

@prafulla: please commit this patch.

-- 
Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-16 20:42     ` Michael Walle
@ 2011-10-17 10:22       ` Prafulla Wadaskar
  0 siblings, 0 replies; 7+ messages in thread
From: Prafulla Wadaskar @ 2011-10-17 10:22 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Michael Walle [mailto:michael at walle.cc]
> Sent: Monday, October 17, 2011 2:13 AM
> To: Wolfgang Denk
> Cc: u-boot at lists.denx.de; Prafulla Wadaskar
> Subject: Re: [PATCH] kirkwood_spi: add dummy spi_init()
> 
> Hi Wolfgang,
> 
> Am Sonntag 16 Oktober 2011, 22:25:11 schrieb Wolfgang Denk:
> > In message <201110162032.02236.michael@walle.cc> you wrote:
> > > > The spi_init() function is missing. Add it.
> > > >
> > > > Signed-off-by: Michael Walle <michael@walle.cc>
> >
> > ...
> >
> > > could you commit this small patch? (acked by mike)
> >
> > No, I cannot.  This is kirkwood related and thus has to go through the
> > Marvell custodian.
> oh sorry :)
> 
> > You had him on Cc: ?
> No, but now.
> 
> @prafulla: please commit this patch.

Sure, I will review and do it by tomorrow

Regards..
Prafulla . .

> 
> --
> Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
  2011-10-06 22:23 [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init() Michael Walle
  2011-10-07 17:24 ` Mike Frysinger
  2011-10-16 18:32 ` Michael Walle
@ 2011-10-18 11:09 ` Prafulla Wadaskar
  2 siblings, 0 replies; 7+ messages in thread
From: Prafulla Wadaskar @ 2011-10-18 11:09 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Michael Walle
> Sent: Friday, October 07, 2011 3:54 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
> 
> The spi_init() function is missing. Add it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/spi/kirkwood_spi.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index a1c3070..8c35d5e 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int
> cs)
>  }
>  #endif
> 
> +void spi_init(void)
> +{
> +}
> +
>  void spi_cs_activate(struct spi_slave *slave)
>  {
>  	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);
> --
> 1.7.2.5

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-10-18 11:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 22:23 [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init() Michael Walle
2011-10-07 17:24 ` Mike Frysinger
2011-10-16 18:32 ` Michael Walle
2011-10-16 20:25   ` Wolfgang Denk
2011-10-16 20:42     ` Michael Walle
2011-10-17 10:22       ` Prafulla Wadaskar
2011-10-18 11:09 ` Prafulla Wadaskar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox