From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 17 Oct 2011 19:31:21 +0200
Subject: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and
	write functions
In-Reply-To: <1318864970-11608-3-git-send-email-sherbrec@cit-ec.uni-bielefeld.de>
References: <1318864970-11608-1-git-send-email-sherbrec@cit-ec.uni-bielefeld.de>
	<1318864970-11608-3-git-send-email-sherbrec@cit-ec.uni-bielefeld.de>
Message-ID: <201110171931.22119.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote:
> Signed-off-by: Stefan Herbrechtsmeier <sherbrec@cit-ec.uni-bielefeld.de>
> CC: Marek Vasut <marek.vasut@gmail.com>
> CC: Remy Bohmer  <linux@bohmer.net>
> ---

Hi Stefan,

this patch is awesome, I really need this one. But ...

Can you possibly convert the register definitions to struct based access ?

Like 

struct pxa_usb_regs {
u32 reg1;
u32 reg2;
...
};

and then use it in the functions :

type fn()
{
	struct pxa_usb_regs regs = (struct pxa_usb_regs)0x46000000;
...
	writel(val, &regs->reg1);
}

Thanks!!