From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: prevent libgcc to be linked twice
Date: Tue, 18 Oct 2011 12:06:21 -0400 [thread overview]
Message-ID: <201110181206.22465.vapier@gentoo.org> (raw)
In-Reply-To: <4E9D3923.1050005@atmel.com>
On Tuesday 18 October 2011 04:30:27 Nicolas Ferre wrote:
> On 10/17/2011 07:25 PM, Mike Frysinger :
> > On Monday 17 October 2011 09:41:15 Nicolas Ferre wrote:
> >> If we define USE_PRIVATE_LIBGCC, PLATFORM_LIBS is used during
> >> link. During this last link editing, libgcc may be listed twice
> >> and fail.
> >> Prevent this using "filter-out" in top Makefile.
> >
> > could you please provide more details ? libgcc should not be listed
> > twice.
>
> I compile current u-boot with the flowing command line:
> make -j5 CROSS_COMPILE=arm-linux-gnueabi- USE_PRIVATE_LIBGCC=yes
> at91sam9m10g45ek_nandflash
the issue shows up when using the board shortcut, and only when your tree is
already configured. if you use at91sam9m10g45ek_nandflash_config and then
another make, it works fine. if you start from a clean tree (git clean -x -d),
it works fine.
this is due to PLATFORM_LIBS appending PLATFORM_LIBGCC when the tree has been
configured, then exporting PLATFORM_LIBS, then the board shortcut running
$(MAKE). the exported PLATFORM_LIBS gets LIBGCC appended a second time.
this issue will show up with any value that gets appended to PLATFORM_LIBS and
not just libgcc. the arm code already hits this and deals with it locally.
seems like we should instead unify this logic, or redo PLATFORM_LIBS so that
it isn't an issue in the first place.
-mike
next prev parent reply other threads:[~2011-10-18 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 13:41 [U-Boot] [PATCH] Makefile: prevent libgcc to be linked twice Nicolas Ferre
2011-10-17 17:25 ` Mike Frysinger
2011-10-18 8:30 ` Nicolas Ferre
2011-10-18 16:06 ` Mike Frysinger [this message]
2011-10-20 8:26 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110181206.22465.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox