From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [STATUS] "Quality" of patches / testing.
Date: Tue, 18 Oct 2011 12:24:16 +0200 [thread overview]
Message-ID: <20111018122416.483205d6@lmajewski.digital.local> (raw)
In-Reply-To: <4E9D4552.5040506@gmail.com>
Hi,
> I guess it will be doable to have some scripts/prepare-patch which
> runs a) git format-patch
> b) checkpatch on the patch
I'm a bit confused.
Joe Hershberger has prepared a following patch:
http://patchwork.ozlabs.org/patch/119083/
Is this THE ONE checkpatch version which we shall use (including its
config file)?
I've used it for my patch sets and I can say that warnings like:
WARNING: min() should probably be min_t(unsigned int, amount_left,
mod_data.buflen)
and
WARNING: consider using kstrto* in preference to simple_strtoul
#4358:
are still present.
Those are Linux kernel specific.
Shall I not care about them and submit patches with non zero warnings
output from checkpatch?
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center
Platform Group
next prev parent reply other threads:[~2011-10-18 10:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 6:23 [U-Boot] [STATUS] "Quality" of patches / testing Wolfgang Denk
2011-10-18 6:51 ` Simon Schwarz
2011-10-18 9:22 ` Andreas Bießmann
2011-10-18 9:44 ` Wolfgang Denk
2011-10-18 13:05 ` Jason
2011-10-18 13:10 ` Jason
2011-10-18 13:13 ` Simon Schwarz
2011-10-18 13:49 ` Jason
2011-10-18 15:37 ` Jason
2011-10-18 16:12 ` Mike Frysinger
2011-10-18 13:36 ` Andreas Bießmann
2011-10-18 15:55 ` Jason
2011-10-18 14:05 ` Simon Glass
2011-10-18 16:59 ` Anton Staaf
2011-10-18 20:23 ` Wolfgang Denk
2011-10-20 0:39 ` Simon Glass
2011-10-20 15:32 ` Wolfgang Denk
2011-10-18 10:24 ` Lukasz Majewski [this message]
2011-10-18 11:02 ` Wolfgang Denk
2011-10-18 9:34 ` Wolfgang Denk
2011-10-18 13:05 ` Simon Schwarz
2011-10-18 8:49 ` Lukasz Majewski
2011-10-18 17:01 ` [U-Boot] MAKEALL Mike Frysinger
2011-10-18 17:39 ` Simon Glass
2011-10-18 17:58 ` Tom Rini
2011-10-18 18:11 ` Mike Frysinger
2011-10-18 18:31 ` Mike Frysinger
2011-10-18 18:54 ` Tom Rini
2011-10-18 19:49 ` Mike Frysinger
2011-10-18 20:07 ` Wolfgang Denk
2011-10-18 20:14 ` Mike Frysinger
2011-10-18 20:47 ` Wolfgang Denk
2011-10-18 20:55 ` Mike Frysinger
2011-10-18 21:30 ` Simon Glass
2011-10-18 22:21 ` Mike Frysinger
2011-10-19 11:36 ` Albert ARIBAUD
2011-10-19 14:25 ` Mike Frysinger
2011-10-19 19:57 ` Wolfgang Denk
2011-10-18 21:50 ` Wolfgang Denk
2011-10-18 22:18 ` Mike Frysinger
2011-10-18 22:33 ` Graeme Russ
2011-10-19 7:12 ` Andreas Bießmann
2011-10-19 8:57 ` Wolfgang Denk
2011-10-18 17:16 ` [U-Boot] [STATUS] "Quality" of patches / testing Anton Staaf
2011-10-18 17:44 ` Albert ARIBAUD
2011-10-18 18:07 ` Anton Staaf
2011-10-20 9:25 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018122416.483205d6@lmajewski.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox