From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: add ide initialization
Date: Tue, 18 Oct 2011 18:19:30 -0400 [thread overview]
Message-ID: <201110181819.30957.vapier@gentoo.org> (raw)
In-Reply-To: <4E9DF2C2.2080800@aribaud.net>
On Tuesday 18 October 2011 17:42:26 Albert ARIBAUD wrote:
> Le 07/10/2011 23:50, Michael Walle a ?crit :
> > Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:
> >> On Thursday 06 October 2011 18:23:06 Michael Walle wrote:
> >>> --- a/arch/arm/lib/board.c
> >>> +++ b/arch/arm/lib/board.c
> >>>
> >>> +#if defined(CONFIG_CMD_IDE)
> >>> + puts ("IDE: ");
> >>> + ide_init ();
> >>> +#endif
> >>
> >> NAK: no space before that open paren
> >
> > as long as the style is the only objection, i'm glad to resend a fixed
> > patch
> >
> > :)
> >
> > Albert, are there any other objections?
>
> NAK: the fact that some board has an IDE interface does not mean it must
> initialize it in all boot cases; and the rule with devices in U-Boot is
> 'turn it on *only* when you're about to use it'.
>
> Boards that always want to initialize IDE on boot can and will do so by
> putting 'ide reset' first in their bootcmd environment variable.
ACK to this. would be nice to get existing ports (ppc/m68k/sh/sparc/x86) to
migrate their users to "ide reset" too ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111018/719d932c/attachment.pgp
prev parent reply other threads:[~2011-10-18 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 22:23 [U-Boot] [PATCH] arm: add ide initialization Michael Walle
2011-10-07 17:27 ` Mike Frysinger
2011-10-07 21:50 ` Michael Walle
2011-10-18 21:42 ` Albert ARIBAUD
2011-10-18 22:19 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110181819.30957.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox