From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 18 Oct 2011 18:19:30 -0400 Subject: [U-Boot] [PATCH] arm: add ide initialization In-Reply-To: <4E9DF2C2.2080800@aribaud.net> References: <1317939786-19655-1-git-send-email-michael@walle.cc> <201110072350.20528.michael@walle.cc> <4E9DF2C2.2080800@aribaud.net> Message-ID: <201110181819.30957.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 18 October 2011 17:42:26 Albert ARIBAUD wrote: > Le 07/10/2011 23:50, Michael Walle a ?crit : > > Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger: > >> On Thursday 06 October 2011 18:23:06 Michael Walle wrote: > >>> --- a/arch/arm/lib/board.c > >>> +++ b/arch/arm/lib/board.c > >>> > >>> +#if defined(CONFIG_CMD_IDE) > >>> + puts ("IDE: "); > >>> + ide_init (); > >>> +#endif > >> > >> NAK: no space before that open paren > > > > as long as the style is the only objection, i'm glad to resend a fixed > > patch > > > > :) > > > > Albert, are there any other objections? > > NAK: the fact that some board has an IDE interface does not mean it must > initialize it in all boot cases; and the rule with devices in U-Boot is > 'turn it on *only* when you're about to use it'. > > Boards that always want to initialize IDE on boot can and will do so by > putting 'ide reset' first in their bootcmd environment variable. ACK to this. would be nice to get existing ports (ppc/m68k/sh/sparc/x86) to migrate their users to "ide reset" too ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111018/719d932c/attachment.pgp