public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] mpc85xx: Add inline GPIO acessor functions
Date: Tue, 18 Oct 2011 23:19:37 -0400	[thread overview]
Message-ID: <201110182319.39115.vapier@gentoo.org> (raw)
In-Reply-To: <1318981284-4357-2-git-send-email-Kyle.D.Moffett@boeing.com>

On Tuesday 18 October 2011 19:41:22 Kyle Moffett wrote:
> --- a/README
> +++ b/README
> 
>  - 85xx CPU Options:
> +		CONFIG_MPC85XX_GENERIC_GPIO
> +
> +		Provide a generic gpio_request() interface to the onboard
> +		processor GPIOs in the MPC85XX-series chips.

do you really need a CONFIG knob for this ?  defining this adds no overhead 
that i can see.

> --- /dev/null
> +++ b/arch/powerpc/include/asm/mpc85xx_gpio.h

missing #ifdef protection against multiple inclusion
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111018/3d9f535b/attachment.pgp 

  reply	other threads:[~2011-10-19  3:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18 23:41 [U-Boot] [PATCH 0/3] mpc85xx: HWW-1U-1A board support patches Kyle Moffett
2011-10-18 23:41 ` [U-Boot] [PATCH 1/3] mpc85xx: Add inline GPIO acessor functions Kyle Moffett
2011-10-19  3:19   ` Mike Frysinger [this message]
2011-10-19 13:51     ` Kumar Gala
2011-10-19 18:21       ` Moffett, Kyle D
2011-10-19 18:58         ` [U-Boot] [PATCH 2/3] " Kyle Moffett
2011-10-21  5:07           ` Kumar Gala
2011-10-18 23:41 ` [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook Kyle Moffett
2011-10-19  3:20   ` Mike Frysinger
2011-10-19 18:26     ` Moffett, Kyle D
2011-10-19 18:52       ` Mike Frysinger
2011-10-19 20:33         ` Wolfgang Denk
2011-10-19 20:35       ` Wolfgang Denk
2011-10-19 21:05         ` Moffett, Kyle D
2011-10-19 21:55           ` Mike Frysinger
2011-10-19 22:52             ` Moffett, Kyle D
2011-10-20  0:15               ` Mike Frysinger
2011-10-20  0:23                 ` Moffett, Kyle D
2011-10-20  1:31                   ` Mike Frysinger
2011-10-20 15:30                   ` Wolfgang Denk
2011-10-20 14:02           ` Wolfgang Denk
2011-10-20 17:45             ` Moffett, Kyle D
2011-10-20 19:28               ` Wolfgang Denk
2011-10-18 23:41 ` [U-Boot] [PATCH 3/3] mpc85xx: Add board support for the eXMeritus HWW-1U-1A devices Kyle Moffett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110182319.39115.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox