From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Wed, 19 Oct 2011 10:27:07 +0200 Subject: [U-Boot] [PATCH V3 3/4] video: add access to GraphicDevice struct In-Reply-To: <729c1deae7a3d6def98c023f0239390b8f017c71.1318928915.git.clchiou@chromium.org> References: <729c1deae7a3d6def98c023f0239390b8f017c71.1318928915.git.clchiou@chromium.org> Message-ID: <20111019102707.111b36e4@wker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On Tue, 18 Oct 2011 17:15:37 +0800 Che-Liang Chiou wrote: > video_hw_init() returns this struct, which is quite useful, but it is > probably not okay to call this function multiple times. So this patch > adds video_devinfo() that does nothing but return this struct. > > video_devinfo() does not guarantee that this struct is initialized. It > is user's responsibility to make sure that the video device is properly > initialized. > > Signed-off-by: Che-Liang Chiou > --- > > Changes in V3 > Add to the patch set > > board/eltec/mhpc/mhpc.c | 7 +++++++ > drivers/video/ati_radeon_fb.c | 5 +++++ > drivers/video/ct69000.c | 5 +++++ > drivers/video/fsl_diu_fb.c | 8 +++++++- > drivers/video/mb862xx.c | 5 +++++ > drivers/video/mb86r0xgdc.c | 5 +++++ > drivers/video/mx3fb.c | 5 +++++ > drivers/video/mxc_ipuv3_fb.c | 5 +++++ > drivers/video/sed13806.c | 6 ++++++ > drivers/video/sm501.c | 5 +++++ > drivers/video/smiLynxEM.c | 5 +++++ NAK. Better would be to add video_devinfo() only to drivers/video/cfb_console.c since the graphic device structure pointer is stored there. We do not need to add this function to each video driver. Anatolij