From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port
Date: Wed, 19 Oct 2011 10:36:08 -0400 [thread overview]
Message-ID: <201110191036.08896.vapier@gentoo.org> (raw)
In-Reply-To: <48D3D52125C49B43AE880038E2E5314BB5BEF5@SRV101.gdsys.de>
On Wednesday 19 October 2011 04:37:26 Eibach, Dirk wrote:
> > While looking again, I noticed that you are not using the
> > "standard" GPIO API borrowed from Linux. Please take a look
> > at drivers/gpio/mxc_gpio.c or drivers/gpio/mvgpio.c as an example.
> >
> > Sorry for not mentioning this earlier. Could you please
> > update this patch and your Io64 BSP patch by using this
> > "standard" GPIO API?
>
> I see that the drivers you mentioned are for processor gpio, mine is for
> an i2c port expander.
> The gpio API "implementation" in these drivers is a mess because it does
> not support managing multiple gpio providers. Using this API would make
> it impossible to use pca9698 on such platforms. If someone decided to
> build a processor gpio driver like this for ppc4xx we would even have a
> collision for Io64.
>
> Until the whole GPIO API idea is more refined I am not too happy
> adapting pca9698 implementation.
> Do you insist?
the GPIO API is not specific to processors. atm, only SoC's are implementing
it. what you're looking for is the gpiolib which Linux supports. we haven't
bothered adding that layer yet as no one was adding GPIO expanders.
you still have your API logically line up with the common GPIO API so that
when said layer lands, it's easy to transition to.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111019/816872e3/attachment.pgp
next prev parent reply other threads:[~2011-10-19 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 6:34 [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port Dirk Eibach
2011-10-19 7:48 ` Stefan Roese
2011-10-19 8:37 ` Eibach, Dirk
2011-10-19 14:36 ` Mike Frysinger [this message]
2011-10-20 6:45 ` Stefan Roese
2011-10-19 14:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110191036.08896.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox