From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook
Date: Wed, 19 Oct 2011 14:52:24 -0400 [thread overview]
Message-ID: <201110191452.26073.vapier@gentoo.org> (raw)
In-Reply-To: <7C2673D7-CC5C-490C-9809-06C9A207154F@boeing.com>
On Wednesday 19 October 2011 14:26:03 Moffett, Kyle D wrote:
> On Oct 18, 2011, at 23:20, Mike Frysinger wrote:
> > On Tuesday 18 October 2011 19:41:23 Kyle Moffett wrote:
> >> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> >> +{
> >>
> >> unsigned long val, msr;
> >>
> >> + /* Allow boards to override the reset */
> >> + int err = __board_restart();
> >> + if (err)
> >> + return err;
> >
> > i thought we decided that do_reset() shouldn't return
>
> For our hardware we have to coordinate reset between both CPUs on the
> same physical board, so a "reset" command may hang indefinitely waiting
> for the other CPU (IE: If it refuses to shutdown in Linux or is running
> U-Boot).
>
> So for user convenience I need to be able to Ctrl-C the communication.
> Since "reset" is basically just like any other U-Boot shell command,
> (except with some side-effects) it seems reasonable to allow a board
> handler to return an error instead of resetting.
i thought this came up before and we said "no". but Wolfgang was more
involved in that discussion, so he should be able to better say.
this is probably in the mail archives somewhere too ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111019/aecb00e2/attachment.pgp
next prev parent reply other threads:[~2011-10-19 18:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 23:41 [U-Boot] [PATCH 0/3] mpc85xx: HWW-1U-1A board support patches Kyle Moffett
2011-10-18 23:41 ` [U-Boot] [PATCH 1/3] mpc85xx: Add inline GPIO acessor functions Kyle Moffett
2011-10-19 3:19 ` Mike Frysinger
2011-10-19 13:51 ` Kumar Gala
2011-10-19 18:21 ` Moffett, Kyle D
2011-10-19 18:58 ` [U-Boot] [PATCH 2/3] " Kyle Moffett
2011-10-21 5:07 ` Kumar Gala
2011-10-18 23:41 ` [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook Kyle Moffett
2011-10-19 3:20 ` Mike Frysinger
2011-10-19 18:26 ` Moffett, Kyle D
2011-10-19 18:52 ` Mike Frysinger [this message]
2011-10-19 20:33 ` Wolfgang Denk
2011-10-19 20:35 ` Wolfgang Denk
2011-10-19 21:05 ` Moffett, Kyle D
2011-10-19 21:55 ` Mike Frysinger
2011-10-19 22:52 ` Moffett, Kyle D
2011-10-20 0:15 ` Mike Frysinger
2011-10-20 0:23 ` Moffett, Kyle D
2011-10-20 1:31 ` Mike Frysinger
2011-10-20 15:30 ` Wolfgang Denk
2011-10-20 14:02 ` Wolfgang Denk
2011-10-20 17:45 ` Moffett, Kyle D
2011-10-20 19:28 ` Wolfgang Denk
2011-10-18 23:41 ` [U-Boot] [PATCH 3/3] mpc85xx: Add board support for the eXMeritus HWW-1U-1A devices Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110191452.26073.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox